Issue 10905206: Update co19 to r336.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905206: Update co19 to r336. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Ivan Posva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update co19 to r336. Committed: https://code.google.com/p/dart/source/detail?r=12160

Patch Set 2 : Rebased #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -154 lines)			Patch
M	dart/tests/co19/co19-compiler.status	View	5 chunks	+28 lines, -33 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	8 chunks	+73 lines, -42 lines	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View	6 chunks	+79 lines, -78 lines	0 comments	Download
M	deps/all.deps/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10905206/diff/1/dart/tests/co19/co19-compiler.status File dart/tests/co19/co19-compiler.status (right): https://chromiumcodereview.appspot.com/10905206/diff/1/dart/tests/co19/co19-compiler.status#newcode778 dart/tests/co19/co19-compiler.status:778: Language/07_Classes/2_Getters_A02_t01: Fail, Pass Do you know why a ...

8 years, 3 months ago (2012-09-11 06:34:48 UTC) #2

ahe

I have filed http://dartbug.com/5064 as the analyzer is effectively ignoring more than 1000 tests. https://chromiumcodereview.appspot.com/10905206/diff/1/dart/tests/co19/co19-compiler.status ...

8 years, 3 months ago (2012-09-11 07:09:25 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 10905206: Update co19 to r336. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Messages