Look for git.cmd on Windows.

utils/pub/io.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Helper functionality to make working with IO easier.
  */
 #library('io');
 
 #import('dart:io');
 #import('dart:isolate');
 #import('dart:uri');
+#import('utils.dart');
 
 /** Gets the current working directory. */
 String get workingDir => new File('.').fullPathSync();
 
 /**
  * Prints the given string to `stderr` on its own line.
  */
 void printError(value) {
   stderr.writeString(value.toString());
   stderr.writeString('\n');
@@ skipping 443 matching lines @@
     return true;
   });
   input.then((value) {
     if (completer.future.isComplete) return;
     timer.cancel();
     completer.complete(value);
   });
   return completer.future;
 }
 
-/**
- * Tests whether or not the git command-line app is available for use.
- */
-Future<bool> get isGitInstalled {
-  // TODO(rnystrom): We could cache this after the first check. We aren't right
-  // now because Future.immediate() will invoke its callback synchronously.
-  // That does bad things in cases where the caller expects futures to always
-  // be async. In particular, withGit() in the pub tests which calls
-  // expectAsync() will fail horribly if the test isn't actually async.
+/// The cached Git command.
+String _gitCommand;
 
+/// Tests whether or not the git command-line app is available for use.
+Future<bool> get isGitInstalled => gitCommand.transform((git) => git != null);
+
+/// Returns the name of the git command-line app, or null if Git could not be
+/// found on the user's PATH.
+Future<String> get gitCommand {

[Bob Nystrom, 2012/09/11 16:18:55]

I would unify this with _runGit and just have a single method that invokes git
in an appropriate way.

[nweiz, 2012/09/11 19:25:11]

Done.

+  // TODO(nweiz): Just use Future.immediate once issue 3356 is fixed.
+  if (_gitCommand != null) return sleep(0).transform((_) => _gitCommand);
+
+  return _tryGitCommand("git").chain((success) {
+    if (success) return new Future.immediate("git");
+
+    // Git is sometimes installed on Windows as `git.cmd`
+    return _tryGitCommand("git.cmd").transform((success) {
+      if (success) return "git.cmd";
+      return null;
+    });
+  });
+}
+
+/// Checks whether [command] is the Git command for this computer.
+Future<bool> _tryGitCommand(String command) {
   var completer = new Completer<bool>();
 
   // If "git --version" prints something familiar, git is working.
-  var future = runProcess("git", ["--version"]);
+  var future = runProcess(command, ["--version"]);
 
   future.then((results) {
     var regex = new RegExp("^git version");
     completer.complete(results.stdout.length == 1 &&
                        regex.hasMatch(results.stdout[0]));
   });
 
   future.handleException((err) {
     // If the process failed, they probably don't have it.
     completer.complete(false);
@@ skipping 74 matching lines @@
   return new Directory(entry);
 }
 
 /**
  * Gets a [Uri] for [uri], which can either already be one, or be a [String].
  */
 Uri _getUri(uri) {
   if (uri is Uri) return uri;
   return new Uri.fromString(uri);
 }