Move app list

chrome/browser/ui/ash/launcher/browser_launcher_item_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h"
 
 #include <map>
 #include <string>
 
 #include "ash/launcher/launcher_model.h"
@@ skipping 19 matching lines @@
 // TODO(avi): Kill this when TabContents goes away.
 class BrowserLauncherItemControllerContentsCreator {
  public:
   static TabContents* CreateTabContents(content::WebContents* contents) {
     return TabContents::Factory::CreateTabContents(contents);
   }
 };
 
 namespace {
 
+const int kExpectedAppIndex = 2;
+
 // Test implementation of AppTabHelper
 class AppTabHelperImpl : public ChromeLauncherController::AppTabHelper {
  public:
   AppTabHelperImpl() {}
   virtual ~AppTabHelperImpl() {}
 
   // Sets the id for the specified tab. The id is removed if Remove() is
   // invoked.
   void SetAppID(TabContents* tab, const std::string& id) {
     tab_id_map_[tab] = id;
@@ skipping 270 matching lines @@
     scoped_ptr<TabContents> tab1(
         BrowserLauncherItemControllerContentsCreator::CreateTabContents(
             CreateTestWebContents()));
 
   app_tab_helper_->SetAppID(tab1.get(), "1");
 
   app_icon_loader_->GetAndClearFetchCount();
   launcher_delegate_->PinAppWithID("1");
   EXPECT_GT(app_icon_loader_->GetAndClearFetchCount(), 0);
   EXPECT_EQ(ash::TYPE_APP_SHORTCUT,
-            launcher_model_->items()[1].type);
+            launcher_model_->items()[kExpectedAppIndex].type);
   EXPECT_TRUE(launcher_delegate_->IsAppPinned("1"));
   EXPECT_FALSE(launcher_delegate_->IsAppPinned("0"));
   EXPECT_EQ(initial_size + 1, launcher_model_->items().size());
 
   launcher_delegate_.reset(
       new ChromeLauncherController(profile(), launcher_model_.get()));
   app_tab_helper_ = new AppTabHelperImpl;
   app_tab_helper_->SetAppID(tab1.get(), "1");
   ResetAppTabHelper();
   app_icon_loader_ = new AppIconLoaderImpl;
   ResetAppIconLoader();
   launcher_delegate_->Init();
   EXPECT_GT(app_icon_loader_->GetAndClearFetchCount(), 0);
   ASSERT_EQ(initial_size + 1, launcher_model_->items().size());
   EXPECT_TRUE(launcher_delegate_->IsAppPinned("1"));
   EXPECT_FALSE(launcher_delegate_->IsAppPinned("0"));
   EXPECT_EQ(ash::TYPE_APP_SHORTCUT,
-            launcher_model_->items()[1].type);
+            launcher_model_->items()[kExpectedAppIndex].type);
 
   UnpinAppsWithID("1");
   ASSERT_EQ(initial_size, launcher_model_->items().size());
 }
 
 // Confirm that tabbed browsers handle activation correctly.
 TEST_F(BrowserLauncherItemControllerTest, ActivateBrowsers) {
   State state1(this, std::string(), BrowserLauncherItemController::TYPE_TABBED);
 
   // First browser is active.
@@ skipping 71 matching lines @@
   EXPECT_EQ(ash::STATUS_RUNNING, app_state.GetUpdaterItem().status);
 
   // App window should go to attention state.
   app_state.window.SetProperty(aura::client::kDrawAttentionKey, true);
   EXPECT_EQ(ash::STATUS_ATTENTION, app_state.GetUpdaterItem().status);
 
   // Activating app window should clear attention state.
   activation_client_->ActivateWindow(&app_state.window);
   EXPECT_EQ(ash::STATUS_ACTIVE, app_state.GetUpdaterItem().status);
 }