Have different text for apps and regular extensions in some more places.

Have different text for apps and regular extensions in some more places.

BUG=146699
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156622

[Marijn Kruisselbrink, 2012-09-10 18:20:50]

not sure if there are other places that should be fixed to make the distinction
between apps and extensions. the extensions config page is of course an obvious
big one, but I think that is more of a separate issue?

[asargent_no_longer_on_chrome, 2012-09-11 16:17:21]

LGTM

[Marijn Kruisselbrink, 2012-09-11 16:33:02]

sky: can you review the chrome/app/ string changes?

[sky, 2012-09-11 17:37:22]

http://codereview.chromium.org/10905188/diff/7/chrome/app/chromium_strings.grd
File chrome/app/chromium_strings.grd (right):

http://codereview.chromium.org/10905188/diff/7/chrome/app/chromium_strings.gr...
chrome/app/chromium_strings.grd:694: <message name="IDS_APP_ALERT_ITEM_EXTERNAL"
desc="A statement that an external packaged app has been newly installed. End
users have no idea what an 'external' app is, so we simply call them apps. The
trailing character must be a newline.">
Any reason for forcing the newline in these messages?

http://codereview.chromium.org/10905188/diff/7/chrome/app/google_chrome_strin...
File chrome/app/google_chrome_strings.grd (right):

http://codereview.chromium.org/10905188/diff/7/chrome/app/google_chrome_strin...
chrome/app/google_chrome_strings.grd:619: The app "<ph
name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>" has been added.
This doesn't mention chrome, any reason to have it in google_chrome_strings.grd?

[Marijn Kruisselbrink, 2012-09-11 18:03:38]

http://codereview.chromium.org/10905188/diff/7/chrome/app/chromium_strings.grd
File chrome/app/chromium_strings.grd (right):

http://codereview.chromium.org/10905188/diff/7/chrome/app/chromium_strings.gr...
chrome/app/chromium_strings.grd:694: <message name="IDS_APP_ALERT_ITEM_EXTERNAL"
desc="A statement that an external packaged app has been newly installed. End
users have no idea what an 'external' app is, so we simply call them apps. The
trailing character must be a newline.">
On 2012/09/11 17:37:23, sky wrote:
> Any reason for forcing the newline in these messages?
Because the code that uses these potentially concatenates several of these
strings for multiple extensions/apps, and they should all end up on their own
line. Maybe it would indeed be better to change that code to add the newline
there instead of having the newline in all of the strings that can be used
there.

http://codereview.chromium.org/10905188/diff/7/chrome/app/google_chrome_strin...
File chrome/app/google_chrome_strings.grd (right):

http://codereview.chromium.org/10905188/diff/7/chrome/app/google_chrome_strin...
chrome/app/google_chrome_strings.grd:619: The app "<ph
name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>" has been added.
On 2012/09/11 17:37:23, sky wrote:
> This doesn't mention chrome, any reason to have it in
google_chrome_strings.grd?
The reason I put it here is because IDS_EXTENSION_ALERT_ITEM_EXTERNAL is here
too. That one used to refer to chrome until r124874 removed it. Maybe that means
both of these shouldn't be in here

[sky, 2012-09-11 18:16:46]

http://codereview.chromium.org/10905188/diff/7/chrome/app/chromium_strings.grd
File chrome/app/chromium_strings.grd (right):

http://codereview.chromium.org/10905188/diff/7/chrome/app/chromium_strings.gr...
chrome/app/chromium_strings.grd:694: <message name="IDS_APP_ALERT_ITEM_EXTERNAL"
desc="A statement that an external packaged app has been newly installed. End
users have no idea what an 'external' app is, so we simply call them apps. The
trailing character must be a newline.">
On 2012/09/11 18:03:38, Marijn Kruisselbrink wrote:
> On 2012/09/11 17:37:23, sky wrote:
> > Any reason for forcing the newline in these messages?
> Because the code that uses these potentially concatenates several of these
> strings for multiple extensions/apps, and they should all end up on their own
> line. Maybe it would indeed be better to change that code to add the newline
> there instead of having the newline in all of the strings that can be used
> there.

Yes, I think that would be less error prone.

http://codereview.chromium.org/10905188/diff/7/chrome/app/google_chrome_strin...
File chrome/app/google_chrome_strings.grd (right):

http://codereview.chromium.org/10905188/diff/7/chrome/app/google_chrome_strin...
chrome/app/google_chrome_strings.grd:619: The app "<ph
name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>" has been added.
On 2012/09/11 18:03:38, Marijn Kruisselbrink wrote:
> On 2012/09/11 17:37:23, sky wrote:
> > This doesn't mention chrome, any reason to have it in
> google_chrome_strings.grd?
> The reason I put it here is because IDS_EXTENSION_ALERT_ITEM_EXTERNAL is here
> too. That one used to refer to chrome until r124874 removed it. Maybe that
means
> both of these shouldn't be in here

I believe that's right; remove both.

[Marijn Kruisselbrink, 2012-09-13 17:31:24]

http://codereview.chromium.org/10905188/diff/7/chrome/app/chromium_strings.grd
File chrome/app/chromium_strings.grd (right):

http://codereview.chromium.org/10905188/diff/7/chrome/app/chromium_strings.gr...
chrome/app/chromium_strings.grd:694: <message name="IDS_APP_ALERT_ITEM_EXTERNAL"
desc="A statement that an external packaged app has been newly installed. End
users have no idea what an 'external' app is, so we simply call them apps. The
trailing character must be a newline.">
On 2012/09/11 18:16:46, sky wrote:
> On 2012/09/11 18:03:38, Marijn Kruisselbrink wrote:
> > On 2012/09/11 17:37:23, sky wrote:
> > > Any reason for forcing the newline in these messages?
> > Because the code that uses these potentially concatenates several of these
> > strings for multiple extensions/apps, and they should all end up on their
own
> > line. Maybe it would indeed be better to change that code to add the newline
> > there instead of having the newline in all of the strings that can be used
> > there.
> 
> Yes, I think that would be less error prone.

Done.

http://codereview.chromium.org/10905188/diff/7/chrome/app/google_chrome_strin...
File chrome/app/google_chrome_strings.grd (right):

http://codereview.chromium.org/10905188/diff/7/chrome/app/google_chrome_strin...
chrome/app/google_chrome_strings.grd:619: The app "<ph
name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>" has been added.
On 2012/09/11 18:16:46, sky wrote:
> On 2012/09/11 18:03:38, Marijn Kruisselbrink wrote:
> > On 2012/09/11 17:37:23, sky wrote:
> > > This doesn't mention chrome, any reason to have it in
> > google_chrome_strings.grd?
> > The reason I put it here is because IDS_EXTENSION_ALERT_ITEM_EXTERNAL is
here
> > too. That one used to refer to chrome until r124874 removed it. Maybe that
> means
> > both of these shouldn't be in here
> 
> I believe that's right; remove both.

Done.

[sky, 2012-09-13 18:26:10]

LGTM (I only looked at grd files)

[commit-bot: I haz the power, 2012-09-13 18:32:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mek@chromium.org/10905188/6002

[commit-bot: I haz the power, 2012-09-13 20:29:30]

Change committed as 156622