webkit/support/webkit_support.gyp - Issue 10905184: Build the user_agent target for iOS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/support/webkit_support.gyp

Issue 10905184: Build the user_agent target for iOS (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'includes': [	6 'includes': [

7 '../../build/win_precompile.gypi',

8 '../appcache/webkit_appcache.gypi',

9 '../base/webkit_base.gypi',

10 '../blob/webkit_blob.gypi',

11 '../database/webkit_database.gypi',

12 '../dom_storage/webkit_dom_storage.gypi',

13 '../fileapi/webkit_fileapi.gypi',

14 '../forms/webkit_forms.gypi',

15 '../glue/webkit_glue.gypi',

16 '../gpu/webkit_gpu.gypi',

17 '../media/webkit_media.gypi',

18 '../quota/webkit_quota.gypi',

19 '../user_agent/webkit_user_agent.gypi',	7 '../user_agent/webkit_user_agent.gypi',

20 'webkit_support.gypi',	8 ],

	9 'conditions': [

	10 # TODO(stuartmorgan): All dependencies from code built on iOS to

	11 # webkit/ should be removed, at which point this condition can be

	12 # removed.
	tony 2012/09/10 17:15:17 Is it problematic to include the gypi files but no Is it problematic to include the gypi files but not depend on any of the unused targets in the iOS build? That seems like it would be cleaner (this file would be unchanged, but all.gyp would be a bit more complicated). That is, rather than depending on webkit_support.gyp:, the iOS build would just depend on the specific targets it needs. stuartmorgan* 2012/09/11 09:42:54 Yes. Project file generation is per gyp file, not Show quoted text On 2012/09/10 17:15:17, tony wrote: > Is it problematic to include the gypi files but not depend on any of the unused > targets in the iOS build? Yes. Project file generation is per gyp file, not per target, so gyp would attempt to create all the targets from all the gypi files. It would be really annoying to have targets that can't be built in the project, but more importantly it would fail generation because some of the targets in turn depend on gyp files that don't exist in the iOS tree, or that have an unsupported type. So all the targets in all the gypi files would have to be made at least iOS-generation-clean, which would be a bunch of changes that wouldn't really make sense.
	13 ['OS != "ios"', {

	14 'includes': [

	15 '../../build/win_precompile.gypi',

	16 '../appcache/webkit_appcache.gypi',

	17 '../base/webkit_base.gypi',

	18 '../blob/webkit_blob.gypi',

	19 '../database/webkit_database.gypi',

	20 '../dom_storage/webkit_dom_storage.gypi',

	21 '../fileapi/webkit_fileapi.gypi',

	22 '../forms/webkit_forms.gypi',

	23 '../glue/webkit_glue.gypi',

	24 '../gpu/webkit_gpu.gypi',

	25 '../media/webkit_media.gypi',

	26 '../quota/webkit_quota.gypi',

	27 'webkit_support.gypi',

	28 ],

	29 }],

21 ],	30 ],

22 }	31 }

OLD	NEW

« no previous file with comments | « build/all.gyp ('k') | webkit/user_agent/user_agent_util_ios.mm » ('j') | webkit/user_agent/user_agent_util_ios.mm » ('J')