Issue 10905179: Make OwnerKeyUtil thread safe as originally intended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905179: Make OwnerKeyUtil thread safe as originally intended. (Closed)

Created:
8 years, 3 months ago by Mattias Nissler (ping if slow)

Modified:
8 years, 3 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make OwnerKeyUtil thread safe as originally intended. There are actually crash reports that indicate a crash when chromeos::SessionManagerOperation::LoadOwnerKey() calls into util->IsPublicKeyPresent(). The available data points at the vtable contents being invalid, which can happen due to improperly using base::RefCounted instead of base::RefCountedThreadSafe. BUG=chromium:147334 TEST=Less crashes. Manual or automated test not practical, search the crash database for SessionManagerOperation::LoadOwnerKey() and check that there are no crashes after the fix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155714

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/settings/owner_key_util.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/10905179/1

8 years, 3 months ago (2012-09-10 11:09:36 UTC) #3

Change committed as 155714

Expand Messages | Collapse Messages