Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 10905150: Update all.gyp to reflect the current state of the iOS build (Closed)

Created:
8 years, 3 months ago by stuartmorgan
Modified:
8 years, 3 months ago
Reviewers:
qsr
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update all.gyp to reflect the current state of the iOS build A number of targets that now build on iOS never got moved in all.gyp. Also removes the comments, since they are now misleading given that most of the targets that are likely to be brought up on iOS are now working. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M build/all.gyp View 5 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
8 years, 3 months ago (2012-09-07 13:38:24 UTC) #1
qsr
lgtm
8 years, 3 months ago (2012-09-07 13:55:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10905150/1
8 years, 3 months ago (2012-09-07 14:19:16 UTC) #3
commit-bot: I haz the power
Try job failure for 10905150-1 (retry) on mac_rel for step "sync_integration_tests". It's a second try, ...
8 years, 3 months ago (2012-09-07 16:14:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10905150/1
8 years, 3 months ago (2012-09-07 17:07:56 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 19:40:30 UTC) #6
Change committed as 155454

Powered by Google App Engine
This is Rietveld 408576698