Issue 10905142: Rename GData to Drive in drive_file_system_util

Issue 10905142: Rename GData to Drive in drive_file_system_util (Closed)

Created:
8 years, 3 months ago by kochi

Modified:
8 years, 3 months ago

Reviewers:
Daniel Erat, Evan Stade, Aaron Boodman, ahendrickson, satorux1, Ben Goodger (Google), kinaba

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, achuith+watch_chromium.org, rdsmith+dwatch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, satorux1, kinuko, nhiroki, Daniel Erat

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename GData to Drive in drive_file_system_util In this CL, the following functions in gdata::util namespace are renamed: * GetGDataMountPointPath() -> GetDriveMountPointPath() * GetGDataMountPointPathAsString() -> GetDriveMountPointPathAsString() * ModifyGDataFileResourceUrl() -> ModifyDriveFileResourceUrl() * IsUnderGDataMountPoint() -> IsUnderDriveMountPoint() * ExtractGDataPath() -> ExtractDrivePath() BUG=137151 TEST=pass all existing tests. TBR=derat@chromium.org, satorux@chromium.org, aa@chromium.org, estade@chromium.org, ahendrickson@chromium.org, ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155334

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -91 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_handler_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	8 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_handler_util.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_download_observer.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_file_system_util.h	View	4 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_file_system_util.cc	View	7 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_file_system_util_unittest.cc	View	1 chunk	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_system_service.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_prefs.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/save_package_file_picker_chromeos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_installer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/screenshot_taker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/feedback_ui.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/screenshot_source.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kochi

Added TBR= for chrome/browser/ui/ash : derat@ chrome/browser/chromeos/extensions : satorux@ chrome/browser/chromeos : satorux@ chrome/browser/extensions : aa@ ...

8 years, 3 months ago (2012-09-07 05:42:29 UTC) #3

lgtm

Expand Messages | Collapse Messages