Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: build/android/pylib/test_options_parser.py

Issue 10905138: Add test jar generation logic for ant builds. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix indent in base.gyp. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/test_options_parser.py
diff --git a/build/android/pylib/test_options_parser.py b/build/android/pylib/test_options_parser.py
index b1f65691915a4a35d3219f6d332ffa26436ac3c2..6b6964da0b6a8cad87932e226f7ff5ec6ecb1030 100644
--- a/build/android/pylib/test_options_parser.py
+++ b/build/android/pylib/test_options_parser.py
@@ -85,9 +85,8 @@ def ParseInstrumentationArgs(args):
option_parser.add_option('--test-apk', dest='test_apk',
help=('The name of the apk containing the tests '
'(without the .apk extension) or for SDK '
- 'builds, the path to the APK from '
- 'out/(Debug|Release) (for example, '
- 'content_shell_test/ContentShellTest-debug).'))
+ 'builds, the apk name without the debug'
+ ' suffix. for example, ContentShellTest).'))
cjhopman 2012/09/06 22:33:41 Nit: Capitalize "for".
shashi 2012/09/07 00:41:33 Done.
option_parser.add_option('--screenshot', dest='screenshot_failures',
action='store_true',
help='Capture screenshots of test failures')
@@ -116,12 +115,15 @@ def ParseInstrumentationArgs(args):
elif options.python_only:
options.run_java_tests = False
+ # In case of SDK Build, the jars and apks have a debug suffix.
cjhopman 2012/09/06 22:33:41 have a -debug suffix.
shashi 2012/09/07 00:41:33 Done.
options.test_apk_path = os.path.join(_SDK_OUT_DIR,
options.build_type,
- '%s.apk' % options.test_apk)
+ constants.SDK_BUILD_APKS_DIR,
+ '%s-debug.apk' % options.test_apk)
options.test_apk_jar_path = os.path.join(_SDK_OUT_DIR,
options.build_type,
- '%s.jar'
+ constants.SDK_BUILD_TEST_JAVALIB_DIR,
+ '%s-debug.jar'
% options.test_apk)
if options.annotation_str:
options.annotation = options.annotation_str.split()

Powered by Google App Engine
This is Rietveld 408576698