Issue 10905134: use lock to make sure device will not deliver any frame after it's stopped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905134: use lock to make sure device will not deliver any frame after it's stopped. (Closed)

Created:
8 years, 3 months ago by wjia(left Chromium)

Modified:
8 years, 3 months ago

Reviewers:
Ronghua Wu (Left Chromium)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

use lock to make sure device will not deliver any frame after it's stopped. BUG=139004 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155250

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	media/video/capture/mac/video_capture_device_mac.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	media/video/capture/mac/video_capture_device_mac.mm	View		3 chunks	+10 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ronghua Wu (Left Chromium)

Don't have a better idea other than the lock. Hopefully this will fix the problem. ...

8 years, 3 months ago (2012-09-06 20:48:38 UTC) #2

wjia(left Chromium)

8 years, 3 months ago (2012-09-06 20:59:15 UTC) #3

https://chromiumcodereview.appspot.com/10905134/diff/1/media/video/capture/ma...
File media/video/capture/mac/video_capture_device_mac.mm (right):

https://chromiumcodereview.appspot.com/10905134/diff/1/media/video/capture/ma...
media/video/capture/mac/video_capture_device_mac.mm:130: state_ = kIdle;
On 2012/09/06 20:48:38, Ronghua Wu wrote:
> Do we need the lock here?

Init() is called only when the instance is created. There would be no racing
here.

Expand Messages | Collapse Messages