Update PP_InputEvent_Modifier enum to match WebInputEvent::Modifiers

ppapi/api/ppb_input_event.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * This file defines the Input Event interfaces.
  */
 
 label Chrome {
   M13 = 1.0,
   M14 = 1.1

[dmichael (off chromium), 2012/09/11 15:20:01]

Should we consider reving this?

If we leave it alone, old plugins should still work, unless they're doing
something silly like asserting the other bits aren't set, or comparing the
modifiers to an absolute value. I think we can live with that.

New Flash built against this interface might try to use the new modifiers on old
Chrome, and they'll never be set. I'm guessing that's probably okay, but wanted
to make sure you guys had thought about it. The advantage to reving the
interface is you can at least tell which behavior you'll get.

[raymes, 2012/09/11 21:52:01]

Thanks, yeh I did think about this and in practice it's not going to break
anything (as you mentioned). Talked to Brett and he's happy not revving it.

On 2012/09/11 15:20:01, dmichael wrote:

 };
 
 /**
  * This enumeration contains the types of input events.
  */
 [assert_size(4)]
 enum PP_InputEvent_Type {
   PP_INPUTEVENT_TYPE_UNDEFINED = -1,
 
   /**
@@ skipping 166 matching lines @@
   PP_INPUTEVENT_MODIFIER_SHIFTKEY         = 1 << 0,
   PP_INPUTEVENT_MODIFIER_CONTROLKEY       = 1 << 1,
   PP_INPUTEVENT_MODIFIER_ALTKEY           = 1 << 2,
   PP_INPUTEVENT_MODIFIER_METAKEY          = 1 << 3,
   PP_INPUTEVENT_MODIFIER_ISKEYPAD         = 1 << 4,
   PP_INPUTEVENT_MODIFIER_ISAUTOREPEAT     = 1 << 5,
   PP_INPUTEVENT_MODIFIER_LEFTBUTTONDOWN   = 1 << 6,
   PP_INPUTEVENT_MODIFIER_MIDDLEBUTTONDOWN = 1 << 7,
   PP_INPUTEVENT_MODIFIER_RIGHTBUTTONDOWN  = 1 << 8,
   PP_INPUTEVENT_MODIFIER_CAPSLOCKKEY      = 1 << 9,
-  PP_INPUTEVENT_MODIFIER_NUMLOCKKEY       = 1 << 10
+  PP_INPUTEVENT_MODIFIER_NUMLOCKKEY       = 1 << 10,
+  PP_INPUTEVENT_MODIFIER_ISLEFT           = 1 << 11,
+  PP_INPUTEVENT_MODIFIER_ISRIGHT          = 1 << 12
 };
 
 /**
  * This enumeration contains constants representing each mouse button. To get
  * the mouse button for a mouse down or up event, use GetMouseButton on
  * PPB_InputEvent.
  */
 [assert_size(4)]
 enum PP_InputEvent_MouseButton {
   PP_INPUTEVENT_MOUSEBUTTON_NONE   = -1,
@@ skipping 183 matching lines @@
    */
   void ClearInputEventRequest([in] PP_Instance instance,
                               [in] uint32_t event_classes);
 
   /**
    * IsInputEvent() returns true if the given resource is a valid input event
    * resource.
    *
    * @param[in] resource A <code>PP_Resource</code> corresponding to a generic
    * resource.
-   * 
+   *
    * @return <code>PP_TRUE</code> if the given resource is a valid input event
    * resource.
    */
   PP_Bool IsInputEvent([in] PP_Resource resource);
 
   /**
    * GetType() returns the type of input event for the given input event
-   * resource. 
+   * resource.
    *
    * @param[in] resource A <code>PP_Resource</code> corresponding to an input
    * event.
    *
-   * @return A <code>PP_InputEvent_Type</code> if its a valid input event or 
+   * @return A <code>PP_InputEvent_Type</code> if its a valid input event or
    * <code>PP_INPUTEVENT_TYPE_UNDEFINED</code> if the resource is invalid.
    */
   PP_InputEvent_Type GetType([in] PP_Resource event);
 
   /**
    * GetTimeStamp() Returns the time that the event was generated. This will be
    *  before the current time since processing and dispatching the event has
    * some overhead. Use this value to compare the times the user generated two
    * events without being sensitive to variable processing time.
    *
    * @param[in] resource A <code>PP_Resource</code> corresponding to the event.
-   * 
+   *
    * @return The return value is in time ticks, which is a monotonically
    * increasing clock not related to the wall clock time. It will not change
    * if the user changes their clock or daylight savings time starts, so can
    * be reliably used to compare events. This means, however, that you can't
    * correlate event times to a particular time of day on the system clock.
    */
   PP_TimeTicks GetTimeStamp([in] PP_Resource event);
 
   /**
    * GetModifiers() returns a bitfield indicating which modifiers were down
@@ skipping 295 matching lines @@
    */
   PP_Resource Create([in] PP_Instance instance,
                      [in] PP_InputEvent_Type type,
                      [in] PP_TimeTicks time_stamp,
                      [in] uint32_t modifiers,
                      [in] uint32_t key_code,
                      [in] PP_Var character_text);
 
   /**
    * IsKeyboardInputEvent() determines if a resource is a keyboard event.
-   * 
+   *
    * @param[in] resource A <code>PP_Resource</code> corresponding to an event.
    *
    * @return <code>PP_TRUE</code> if the given resource is a valid input event.
    */
   PP_Bool IsKeyboardInputEvent([in] PP_Resource resource);
 
   /**
    * GetKeyCode() returns the DOM keyCode field for the keyboard event.
    * Chrome populates this with the Windows-style Virtual Key code of the key.
    *
@@ skipping 133 matching lines @@
    * @param[in] list The list.
    *
    * @param[in] touch_id The id of the touch-point.
    *
    * @return A <code>PP_TouchPoint</code> representing the touch-point.
    */
   PP_TouchPoint GetTouchById([in] PP_Resource resource,
                              [in] PP_TouchListType list,
                              [in] uint32_t touch_id);
 };