ppapi/cpp/websocket.cc - Issue 10905128: Pepper WebSocket API: Fix memory leak issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/cpp/websocket.cc

Issue 10905128: Pepper WebSocket API: Fix memory leak issue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no leak! Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/cpp/websocket.cc

diff --git a/ppapi/cpp/websocket.cc b/ppapi/cpp/websocket.cc

index 1fbcaa4ede25eb2c882836a8dbc22b5298dd99bc..f0ae5fa0c30075ddef20cfc14a2f0b65983b0833 100644

--- a/ppapi/cpp/websocket.cc

+++ b/ppapi/cpp/websocket.cc

@@ -70,6 +70,10 @@ int32_t WebSocket::ReceiveMessage(Var* message,

if (!has_interface<PPB_WebSocket_1_0>())

return PP_ERROR_BADRESOURCE;

+ // Initialize |message| to release old internal PP_Var of reused |message|.

+ if (message)

+ *message = Var();

return get_interface<PPB_WebSocket_1_0>()->ReceiveMessage(

pp_resource(), const_cast<PP_Var*>(&message->pp_var()),

callback.pp_completion_callback());