Pepper WebSocket API: Fix memory leak issue

ppapi/native_client/src/shared/ppapi_proxy/browser_callback.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "native_client/src/shared/ppapi_proxy/browser_callback.h"
 
 #include <new>
 
 #include "native_client/src/include/nacl_macros.h"
 #include "native_client/src/include/nacl_scoped_ptr.h"
@@ skipping 71 matching lines @@
 
   nacl_abi_size_t read_buffer_size = 0;
   CheckResultFunc check_result_func = remote_callback->check_result_func;
   GetReadSizeFunc get_size_read_func = remote_callback->get_size_read_func;
   if ((*check_result_func)(result) && remote_callback->read_buffer != NULL)
     read_buffer_size = (*get_size_read_func)(result);
   if (remote_callback->read_var.type != PP_VARTYPE_NULL) {
     read_buffer_size = kMaxReturnVarSize;
     read_buffer.reset(
         Serialize(&remote_callback->read_var, 1, &read_buffer_size));
+    PPBVarInterface()->Release(remote_callback->read_var);

[Takashi Toyoshima, 2012/09/07 17:18:27]

This is a renderer process side memory leak.

[dmichael (off chromium), 2012/09/07 18:36:58]

Nice catch!

I have automatic checking for the plugin side for all tests (see test_case.h and
test_case.cc). I'm surprised this isn't showing up in the tests? Maybe we just
aren't reusing a var there?

In any case, I definitely should extend it to check the renderer side...

   }
 
   NaClSrpcError srpc_result =
       CompletionCallbackRpcClient::RunCompletionCallback(
           remote_callback->srpc_channel,
           remote_callback->callback_id,
           result,
           read_buffer_size,
           read_buffer.get());
   DebugPrintf("RunRemoteCallback: %s\n",
@@ skipping 73 matching lines @@
   return MakeRemoteCompletionCallback(srpc_channel, callback_id, 0, NULL);
 }
 
 void DeleteRemoteCallbackInfo(struct PP_CompletionCallback callback) {
   nacl::scoped_ptr<RemoteCallbackInfo> remote_callback(
       reinterpret_cast<RemoteCallbackInfo*>(callback.user_data));
   nacl::scoped_array<char> read_buffer(remote_callback->read_buffer);
 }
 
 }  // namespace ppapi_proxy