Issue 10905117: Safebrowsing malware interstitial UI tweaks.

Issue 10905117: Safebrowsing malware interstitial UI tweaks. (Closed)

Created:
8 years, 3 months ago by mattm

Modified:
8 years, 3 months ago

Reviewers:
Nico, jam, Dan Beam, kewang, Jay Civelli

CC:
chromium-reviews, arv (Not doing code reviews), oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Safebrowsing malware interstitial UI tweaks. BUG=143999, 145319 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155866

Patch Set 2 : hidpi stuff, use webui font #

Total comments: 3

Patch Set 4 : rebase #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -113 lines)			Patch
M	chrome/app/generated_resources.grd	View		5 chunks	+19 lines, -28 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/safe_browsing/malware_block_v2.css	View	1	6 chunks	+33 lines, -35 lines	0 comments	Download
M	chrome/browser/resources/safe_browsing/malware_block_v2.html	View	1	2 chunks	+27 lines, -21 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.cc	View	1	8 chunks	+19 lines, -26 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

mattm

dbeam: chrome/app, chrome/browser/resources/safe_browsing kewang: chrome/browser/safe_browsing screenshots: http://www/~mattm/no_crawl/chrome/sb_interstitial3/

8 years, 3 months ago (2012-09-06 01:14:08 UTC) #1

kewang

lgtm LG to my parts. One side issue, I just noticed that there are two ...

8 years, 3 months ago (2012-09-06 02:02:09 UTC) #2

Dan Beam

http://codereview.chromium.org/10905117/diff/10/chrome/browser/resources/safe_browsing/malware_block_v2.css File chrome/browser/resources/safe_browsing/malware_block_v2.css (right): http://codereview.chromium.org/10905117/diff/10/chrome/browser/resources/safe_browsing/malware_block_v2.css#newcode7 chrome/browser/resources/safe_browsing/malware_block_v2.css:7: font-family: Arial, Helvetica, sans-serif; please fix this to use ...

8 years, 3 months ago (2012-09-06 02:16:32 UTC) #3

mattm

updated. http://www.corp.google.com/~mattm/no_crawl/chrome/sb_interstitial5/ http://codereview.chromium.org/10905117/diff/10/chrome/browser/resources/safe_browsing/malware_block_v2.css File chrome/browser/resources/safe_browsing/malware_block_v2.css (right): http://codereview.chromium.org/10905117/diff/10/chrome/browser/resources/safe_browsing/malware_block_v2.css#newcode7 chrome/browser/resources/safe_browsing/malware_block_v2.css:7: font-family: Arial, Helvetica, sans-serif; On 2012/09/06 02:16:32, ...

8 years, 3 months ago (2012-09-07 18:11:35 UTC) #4

Dan Beam

lgtm w/question http://codereview.chromium.org/10905117/diff/5002/chrome/browser/resources/safe_browsing/malware_block_v2.css File chrome/browser/resources/safe_browsing/malware_block_v2.css (right): http://codereview.chromium.org/10905117/diff/5002/chrome/browser/resources/safe_browsing/malware_block_v2.css#newcode47 chrome/browser/resources/safe_browsing/malware_block_v2.css:47: url('../../../app/theme/%DISTRIBUTION%/product_logo_name_48.png') 1x, I thought there was a ...

8 years, 3 months ago (2012-09-07 22:48:12 UTC) #5

mattm

http://codereview.chromium.org/10905117/diff/5002/chrome/browser/resources/safe_browsing/malware_block_v2.css File chrome/browser/resources/safe_browsing/malware_block_v2.css (right): http://codereview.chromium.org/10905117/diff/5002/chrome/browser/resources/safe_browsing/malware_block_v2.css#newcode47 chrome/browser/resources/safe_browsing/malware_block_v2.css:47: url('../../../app/theme/%DISTRIBUTION%/product_logo_name_48.png') 1x, On 2012/09/07 22:48:12, Dan Beam wrote: > ...

8 years, 3 months ago (2012-09-07 22:53:47 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/10905117/2009

8 years, 3 months ago (2012-09-10 20:36:26 UTC) #10

Change committed as 155866

Expand Messages | Collapse Messages