Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Issue 10905114: Restrict file access on android. (Closed)

Created:
8 years, 3 months ago by nilesh
Modified:
8 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Restrict file access on android. Only files in external storage directory are allowed. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155121

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M chrome/browser/net/chrome_network_delegate.cc View 1 5 chunks +29 lines, -12 lines 0 comments Download
M net/url_request/url_request_file_job.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nilesh
8 years, 3 months ago (2012-09-05 22:56:32 UTC) #1
willchan no longer on Chromium
http://codereview.chromium.org/10905114/diff/1/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): http://codereview.chromium.org/10905114/diff/1/chrome/browser/net/chrome_network_delegate.cc#newcode362 chrome/browser/net/chrome_network_delegate.cc:362: #if defined(OS_CHROMEOS) || defined(OS_ANDROID) How about doing: #if !defined(OS_CHROME) ...
8 years, 3 months ago (2012-09-06 00:20:15 UTC) #2
nilesh
PTAL. http://codereview.chromium.org/10905114/diff/1/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): http://codereview.chromium.org/10905114/diff/1/chrome/browser/net/chrome_network_delegate.cc#newcode362 chrome/browser/net/chrome_network_delegate.cc:362: #if defined(OS_CHROMEOS) || defined(OS_ANDROID) On 2012/09/06 00:20:15, willchan ...
8 years, 3 months ago (2012-09-06 00:26:14 UTC) #3
willchan no longer on Chromium
lgtm
8 years, 3 months ago (2012-09-06 00:33:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10905114/2003
8 years, 3 months ago (2012-09-06 00:35:41 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 04:28:06 UTC) #6
Change committed as 155121

Powered by Google App Engine
This is Rietveld 408576698