Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: tests/language/bad_constructor_test.dart

Issue 10905109: Add named constructor name checking (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | tests/language/function_literals2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/bad_constructor_test.dart
===================================================================
--- tests/language/bad_constructor_test.dart (revision 11966)
+++ tests/language/bad_constructor_test.dart (working copy)
@@ -1,8 +1,8 @@
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+// VMOptions=--constructor_name_check
-
class A {
// Constructor may not be static.
static A(); /// 00: compile-time error
@@ -15,6 +15,16 @@
// Factory may not be abstract
abstract factory A() { return null; } /// 03: compile-time error
+
+ // Named constructor may not conflict with names of methods and fields.
+ var m;
+ A.m() { m = 0; } /// 04: compile-time error
+
+ set q(var value) { m = q; }
+ A.q(); /// 05: compile-time error
+
+ A.foo() : m = 0; /// 06: compile-time error
+ int foo(int a, int b) => a + b * m;
}
main() {
« no previous file with comments | « runtime/vm/parser.cc ('k') | tests/language/function_literals2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698