Issue 10905087: Revert 154861 - Run safebrowsing_service_test through the net testserver code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905087: Revert 154861 - Run safebrowsing_service_test through the net testserver code. (Closed)

Created:
8 years, 3 months ago by mattm

Modified:
8 years, 3 months ago

Reviewers:
mattm

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 154861 - Run safebrowsing_service_test through the net testserver code. Allows us to use ephemeral ports. Also run the testserver.py python process with -u to avoid buffering issues. BUG=96459, 119403 TEST=none Review URL: https://chromiumcodereview.appspot.com/10073033 TBR=mattm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154875

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+465 lines, -617 lines)			Patch
D	chrome/browser/safe_browsing/local_safebrowsing_test_server.h	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/safe_browsing/local_safebrowsing_test_server.cc	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_test.cc	View	11 chunks	+161 lines, -47 lines	0 comments	Download
D	chrome/browser/safe_browsing/safe_browsing_testserver.py	View	1 chunk	+0 lines, -47 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/test/base_test_server.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	net/test/base_test_server.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/test/local_sync_test_server.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/test/local_test_server.h	View	2 chunks	+2 lines, -18 lines	0 comments	Download
M	net/test/local_test_server.cc	View	3 chunks	+4 lines, -23 lines	0 comments	Download
M	net/test/local_test_server_posix.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/test/local_test_server_win.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	net/tools/testserver/run_testserver.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/testserver/testserver.py	View	7 chunks	+292 lines, -235 lines	0 comments	Download
D	net/tools/testserver/testserver_base.py	View	1 chunk	+0 lines, -126 lines	0 comments	Download

Total messages: 1 (0 generated)