ash/wm/workspace/workspace_manager2_unittest.cc - Issue 10905080: Exempt status bubble windows from status bar darkening

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_manager2_unittest.cc

Issue 10905080: Exempt status bubble windows from status bar darkening (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make shelf browser test to confirm that status bubble doesn't cause darkening Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_manager2_unittest.cc

diff --git a/ash/wm/workspace/workspace_manager2_unittest.cc b/ash/wm/workspace/workspace_manager2_unittest.cc

index f337f7fa4d351b49207af09b4ea8f2edee1dae85..3ec6793963b8419a2a1cc3c40fca2b58c8950c74 100644

--- a/ash/wm/workspace/workspace_manager2_unittest.cc

+++ b/ash/wm/workspace/workspace_manager2_unittest.cc

@@ -468,6 +468,13 @@ TEST_F(WorkspaceManager2Test, ShelfStateUpdated) {

w1->SetBounds(touches_shelf_bounds);

EXPECT_FALSE(GetWindowOverlapsShelf());

+ // A visible ignored window should not trigger the overlap.

+ scoped_ptr<Window> w_ignored(CreateTestWindow());

+ w_ignored->SetBounds(touches_shelf_bounds);

+ SetIgnoredByShelf(&(*w_ignored), true);

+ w_ignored->Show();

+ EXPECT_FALSE(GetWindowOverlapsShelf());

// Make it visible, since visible shelf overlaps should be true.

w1->Show();

EXPECT_TRUE(GetWindowOverlapsShelf());