ash/wm/workspace/workspace_manager.cc - Issue 10905080: Exempt status bubble windows from status bar darkening

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_manager.cc

Issue 10905080: Exempt status bubble windows from status bar darkening (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make shelf browser test to confirm that status bubble doesn't cause darkening Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_manager.cc

diff --git a/ash/wm/workspace/workspace_manager.cc b/ash/wm/workspace/workspace_manager.cc

index 42d6d78ec3b92b54485ec04b953419e58b965bf8..95fee2756570ed0ee9319a022dcdaffe898a6abc 100644

--- a/ash/wm/workspace/workspace_manager.cc

+++ b/ash/wm/workspace/workspace_manager.cc

@@ -167,6 +167,9 @@ WorkspaceWindowState WorkspaceManager::GetWindowState() const {

bool has_maximized_window = false;

for (aura::Window::Windows::const_iterator i = windows.begin();

i != windows.end(); ++i) {

+ gfx::Rect b = (*i)->bounds();

+ if (GetIgnoredByShelf(*i))

+ continue;

ui::Layer* layer = (*i)->layer();

if (!layer->GetTargetVisibility() || layer->GetTargetOpacity() == 0.0f)

continue;