Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: chrome/browser/ui/views/frame/browser_view_browsertest.cc

Issue 10905080: Exempt status bubble windows from status bar darkening (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/workspace/workspace_manager_unittest.cc ('k') | chrome/browser/ui/views/status_bubble_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view_browsertest.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_browsertest.cc b/chrome/browser/ui/views/frame/browser_view_browsertest.cc
index ec2a0630e99538cd34137d5c236e849e4497dffe..f64108b9404a58bad6d603f9ae82ce6c5021d7a9 100644
--- a/chrome/browser/ui/views/frame/browser_view_browsertest.cc
+++ b/chrome/browser/ui/views/frame/browser_view_browsertest.cc
@@ -9,6 +9,13 @@
#include "chrome/test/base/in_process_browser_test.h"
#include "ui/views/focus/focus_manager.h"
#include "ui/views/view.h"
+#include "ui/views/widget/widget.h"
+
+#if defined(USE_ASH)
+#include "chrome/browser/ui/views/status_bubble_views.h"
+#include "ui/aura/window.h"
+#include "ash/wm/property_util.h"
+#endif
using views::FocusManager;
using views::View;
@@ -29,3 +36,16 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, DISABLED_FullscreenClearsFocus) {
// Focus is released from the location bar.
EXPECT_FALSE(location_bar_view->Contains(focus_manager->GetFocusedView()));
}
+
+#if defined(USE_ASH)
+// Confirm that status bubble views are not used when determining if the shelf
+// should be darkened.
+IN_PROC_BROWSER_TEST_F(BrowserViewTest, StatusBubble) {
sky 2012/09/04 20:16:05 Is it possible to make this a unit test? By that I
+ StatusBubbleViews* status_bubble = static_cast<StatusBubbleViews*>(
+ browser()->window()->GetStatusBubble());;
+
+ aura::Window* status_window =
+ status_bubble->GetPopupForTest()->GetNativeWindow();
+ EXPECT_TRUE(ash::GetIgnoredByShelf(status_window));
+}
+#endif
« no previous file with comments | « ash/wm/workspace/workspace_manager_unittest.cc ('k') | chrome/browser/ui/views/status_bubble_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698