Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: runtime/bin/socket_win.cc

Issue 10905063: Don't use TEMP_FAILURE_RETRY on windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rename s_addr to socket_addr. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_win.cc
diff --git a/runtime/bin/socket_win.cc b/runtime/bin/socket_win.cc
index 4cc2b8fbad0552f606c0aa9b70f15e99dcebd42a..102f078788c3b952963225c8a1e03f5196880d22 100644
--- a/runtime/bin/socket_win.cc
+++ b/runtime/bin/socket_win.cc
@@ -211,8 +211,8 @@ const char* Socket::LookupIPv4Address(char* host, OSError** os_error) {
intptr_t ServerSocket::CreateBindListen(const char* host,
intptr_t port,
intptr_t backlog) {
- unsigned long s_addr = TEMP_FAILURE_RETRY(inet_addr(host)); // NOLINT
- if (s_addr == INADDR_NONE) {
+ unsigned long socket_addr = inet_addr(host); // NOLINT
+ if (socket_addr == INADDR_NONE) {
return -5;
}
@@ -237,7 +237,7 @@ intptr_t ServerSocket::CreateBindListen(const char* host,
sockaddr_in addr;
memset(&addr, 0, sizeof(addr));
addr.sin_family = AF_INET;
- addr.sin_addr.s_addr = s_addr;
+ addr.sin_addr.s_addr = socket_addr;
addr.sin_port = htons(port);
status = bind(s,
reinterpret_cast<struct sockaddr *>(&addr),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698