Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 10905045: [Sync] Pass ModelTypeSet by value everywhere (Closed)

Created:
8 years, 3 months ago by akalin
Modified:
8 years, 3 months ago
Reviewers:
rlarocque
CC:
chromium-reviews
Visibility:
Public.

Description

[Sync] Pass ModelTypeSet by value everywhere ModelTypeSet is small enough to not need to be passed around by const reference. BUG=145986 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154595

Patch Set 1 #

Patch Set 2 : Sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M sync/engine/all_status.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/all_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/verify_updates_command.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/verify_updates_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/sync_manager.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/invalidation_util.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+rlarocque for review
8 years, 3 months ago (2012-08-31 20:45:11 UTC) #1
rlarocque
LGTM. There's a small chance that this will conflict with http://codereview.chromium.org/10832286/, which is currently in ...
8 years, 3 months ago (2012-08-31 20:51:49 UTC) #2
akalin
On 2012/08/31 20:51:49, rlarocque wrote: > LGTM. > > There's a small chance that this ...
8 years, 3 months ago (2012-09-01 00:33:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10905045/7001
8 years, 3 months ago (2012-09-01 00:48:45 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-01 03:50:31 UTC) #5
Change committed as 154595

Powered by Google App Engine
This is Rietveld 408576698