Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 10905040: Clear in-memory caches of renderers when rules change (Closed)

Created:
8 years, 3 months ago by battre
Modified:
8 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, Matt Perry
Visibility:
Public.

Description

Clear in-memory caches of renderers when rules change If the rules of the declarative WebRequest API change, we need to clear the in-memory caches of the renderers. Otherwise, the new rules may not be visible in the renderers. BUG=112155 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154685

Patch Set 1 #

Patch Set 2 : Previous version was incomplete #

Total comments: 2

Patch Set 3 : Addressed comments #

Messages

Total messages: 6 (0 generated)
battre
Hi Yoyo, could you please review this CL? Thanks. Dominic
8 years, 3 months ago (2012-08-31 12:14:09 UTC) #1
battre
Sorry, the previous version was incomplete. This is better.
8 years, 3 months ago (2012-08-31 12:26:05 UTC) #2
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/10905040/diff/2002/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc File chrome/browser/extensions/api/web_request/web_request_api_helpers.cc (right): https://chromiumcodereview.appspot.com/10905040/diff/2002/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc#newcode1022 chrome/browser/extensions/api/web_request/web_request_api_helpers.cc:1022: namespace { I understand why you might want ...
8 years, 3 months ago (2012-08-31 20:24:57 UTC) #3
battre
https://chromiumcodereview.appspot.com/10905040/diff/2002/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc File chrome/browser/extensions/api/web_request/web_request_api_helpers.cc (right): https://chromiumcodereview.appspot.com/10905040/diff/2002/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc#newcode1022 chrome/browser/extensions/api/web_request/web_request_api_helpers.cc:1022: namespace { On 2012/08/31 20:24:57, Yoyo Zhou wrote: > ...
8 years, 3 months ago (2012-09-03 09:56:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10905040/7002
8 years, 3 months ago (2012-09-03 09:57:01 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-03 12:07:20 UTC) #6
Change committed as 154685

Powered by Google App Engine
This is Rietveld 408576698