content/browser/renderer_host/render_widget_host_impl.cc - Issue 10905036: Pepper Flash Mac: Fix crash when playing video on MB retina

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 10905036: Pepper Flash Mac: Fix crash when playing video on MB retina (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: disable test on windows Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index d30948183c6a35459ec47d4e249f9d7ca3fea4f9..0e6d1eefda5b5c6d2d49d422454201e93b9b5b72 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -1401,8 +1401,8 @@ void RenderWidgetHostImpl::OnMsgUpdateRect(

// and backing store is never used.

if (dib) {

DCHECK(!params.bitmap_rect.IsEmpty());

- const size_t size = params.bitmap_rect.height() *

- params.bitmap_rect.width() * 4;

+ gfx::Size pixel_size = params.bitmap_rect.size().Scale(params.scale_factor);

+ const size_t size = pixel_size.height() * pixel_size.width() * 4;

if (dib->size() < size) {

DLOG(WARNING) << "Transport DIB too small for given rectangle";

RecordAction(UserMetricsAction("BadMessageTerminate_RWH1"));