Pepper Flash Mac: Fix crash when playing video on MB retina

content/browser/renderer_host/render_widget_host_impl.cc

Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index d30948183c6a35459ec47d4e249f9d7ca3fea4f9..0e6d1eefda5b5c6d2d49d422454201e93b9b5b72 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1401,8 +1401,8 @@ void RenderWidgetHostImpl::OnMsgUpdateRect(
   // and backing store is never used.
   if (dib) {
     DCHECK(!params.bitmap_rect.IsEmpty());
-    const size_t size = params.bitmap_rect.height() *
-        params.bitmap_rect.width() * 4;
+    gfx::Size pixel_size = params.bitmap_rect.size().Scale(params.scale_factor);
+    const size_t size = pixel_size.height() * pixel_size.width() * 4;
     if (dib->size() < size) {

[Nico, 2012/08/31 19:46:07]

How was this not broken previously?

[sail, 2012/08/31 19:53:52]

This only breaks when:
  1. The plugin scale factor is different from the page scale factor
  2. and accelerated compositing is disabled.

Even then we still don't hit this code patch because of r139366. Due to that
change GetTransportDIB() returns NULL and this code is never run.

       DLOG(WARNING) << "Transport DIB too small for given rectangle";
       RecordAction(UserMetricsAction("BadMessageTerminate_RWH1"));