Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2588)

Unified Diff: chrome/browser/chromeos/contacts/google_contact_store_unittest.cc

Issue 10905033: contacts: Add ContactMap class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: apply review feedback Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/contacts/google_contact_store_unittest.cc
diff --git a/chrome/browser/chromeos/contacts/google_contact_store_unittest.cc b/chrome/browser/chromeos/contacts/google_contact_store_unittest.cc
index b43a0ea329ce48677fe3d9e9035e56f234f71f73..6bba8683103e48360b1f63d0086491de3dd602f2 100644
--- a/chrome/browser/chromeos/contacts/google_contact_store_unittest.cc
+++ b/chrome/browser/chromeos/contacts/google_contact_store_unittest.cc
@@ -145,7 +145,7 @@ TEST_F(GoogleContactStoreTest, LoadFromGData) {
// The contacts should've been saved to the database, too.
EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()),
- ContactsToString(db_->contacts()));
+ ContactMapToString(db_->contacts()));
}
TEST_F(GoogleContactStoreTest, UpdateFromGData) {
@@ -187,7 +187,7 @@ TEST_F(GoogleContactStoreTest, UpdateFromGData) {
// All three contacts should've been saved to the database.
EXPECT_EQ(VarContactsToString(
3, contact1.get(), contact2.get(), contact3.get()),
- ContactsToString(db_->contacts()));
+ ContactMapToString(db_->contacts()));
EXPECT_EQ(3, db_->num_saved_contacts());
EXPECT_TRUE(test_api_->update_scheduled());
}
@@ -215,7 +215,8 @@ TEST_F(GoogleContactStoreTest, FetchUpdatedContacts) {
ContactPointers loaded_contacts;
store_->AppendContacts(&loaded_contacts);
EXPECT_EQ(ContactsToString(kAllContacts), ContactsToString(loaded_contacts));
- EXPECT_EQ(ContactsToString(kAllContacts), ContactsToString(db_->contacts()));
+ EXPECT_EQ(ContactsToString(kAllContacts),
+ ContactMapToString(db_->contacts()));
EXPECT_EQ(static_cast<int>(kAllContacts.size()), db_->num_saved_contacts());
EXPECT_TRUE(test_api_->update_scheduled());
EXPECT_EQ(1, observer_.num_updates());
@@ -241,7 +242,8 @@ TEST_F(GoogleContactStoreTest, FetchUpdatedContacts) {
loaded_contacts.clear();
store_->AppendContacts(&loaded_contacts);
EXPECT_EQ(ContactsToString(kAllContacts), ContactsToString(loaded_contacts));
- EXPECT_EQ(ContactsToString(kAllContacts), ContactsToString(db_->contacts()));
+ EXPECT_EQ(ContactsToString(kAllContacts),
+ ContactMapToString(db_->contacts()));
EXPECT_EQ(1, db_->num_saved_contacts());
EXPECT_TRUE(test_api_->update_scheduled());
EXPECT_EQ(1, observer_.num_updates());
@@ -259,7 +261,8 @@ TEST_F(GoogleContactStoreTest, FetchUpdatedContacts) {
loaded_contacts.clear();
store_->AppendContacts(&loaded_contacts);
EXPECT_EQ(ContactsToString(kAllContacts), ContactsToString(loaded_contacts));
- EXPECT_EQ(ContactsToString(kAllContacts), ContactsToString(db_->contacts()));
+ EXPECT_EQ(ContactsToString(kAllContacts),
+ ContactMapToString(db_->contacts()));
EXPECT_EQ(1, db_->num_saved_contacts());
EXPECT_TRUE(test_api_->update_scheduled());
EXPECT_EQ(1, observer_.num_updates());

Powered by Google App Engine
This is Rietveld 408576698