Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 10905006: Get semantic capabilities from Print Backend. (Closed)

Created:
8 years, 3 months ago by gene
Modified:
8 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Get semantic capabilities from Print Backend. Moved OS specific code into OS specific print backends (vs. print_system_task_proxy.cc). On Windows get capabilities using native API (vs. XPS parsing) Some clean up on code and interfaces for Print Backend. BUG=144031 TEST=Verify Print Preview on ALL platforms (Win XP, Win 7, Linux, Mac). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155310

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Total comments: 34

Patch Set 16 : #

Patch Set 17 : #

Total comments: 2

Patch Set 18 : #

Patch Set 19 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -760 lines) Patch
M chrome/browser/printing/print_system_task_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +25 lines, -420 lines 0 comments Download
D chrome/browser/printing/print_system_task_proxy_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -321 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +1 line, -10 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -8 lines 0 comments Download
M printing/backend/cups_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +11 lines, -0 lines 0 comments Download
M printing/backend/cups_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +344 lines, -0 lines 0 comments Download
A printing/backend/cups_helper_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +159 lines, -0 lines 0 comments Download
M printing/backend/print_backend.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +22 lines, -0 lines 0 comments Download
M printing/backend/print_backend.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +8 lines, -0 lines 0 comments Download
M printing/backend/print_backend_chromeos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +9 lines, -1 line 0 comments Download
M printing/backend/print_backend_cups.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +14 lines, -0 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +96 lines, -0 lines 0 comments Download
M printing/printing.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Albert Bodenhamer
Let's chat more tomorrow and involve Robert. If we're going to redo a lot of ...
8 years, 3 months ago (2012-08-29 23:54:25 UTC) #1
gene
Yeah, let's chat tomorrow. I would love cleaning JS integration as well. https://chromiumcodereview.appspot.com/10905006/diff/3004/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc ...
8 years, 3 months ago (2012-08-30 03:19:03 UTC) #2
gene1
OK, looks like code is at the point where everything is working and it is ...
8 years, 3 months ago (2012-08-31 21:31:29 UTC) #3
gene
ping :)
8 years, 3 months ago (2012-09-04 22:01:52 UTC) #4
Albert Bodenhamer
I'm setting up test runs on XP and Mac. https://chromiumcodereview.appspot.com/10905006/diff/24009/printing/backend/cups_helper.cc File printing/backend/cups_helper.cc (right): https://chromiumcodereview.appspot.com/10905006/diff/24009/printing/backend/cups_helper.cc#newcode31 printing/backend/cups_helper.cc:31: ...
8 years, 3 months ago (2012-09-04 23:09:36 UTC) #5
gene
https://chromiumcodereview.appspot.com/10905006/diff/24009/printing/backend/cups_helper.cc File printing/backend/cups_helper.cc (right): https://chromiumcodereview.appspot.com/10905006/diff/24009/printing/backend/cups_helper.cc#newcode31 printing/backend/cups_helper.cc:31: #if !defined(OS_MACOSX) 2 functions are ifdef'ed for non-MACOS: parse_lpoptions() ...
8 years, 3 months ago (2012-09-04 23:19:50 UTC) #6
Lei Zhang
a bunch of little things: https://chromiumcodereview.appspot.com/10905006/diff/24009/chrome/browser/printing/print_system_task_proxy.cc File chrome/browser/printing/print_system_task_proxy.cc (right): https://chromiumcodereview.appspot.com/10905006/diff/24009/chrome/browser/printing/print_system_task_proxy.cc#newcode10 chrome/browser/printing/print_system_task_proxy.cc:10: #include <vector> nit: you ...
8 years, 3 months ago (2012-09-05 00:32:32 UTC) #7
gene
Please take a look. Adding more tests in the meantime. https://chromiumcodereview.appspot.com/10905006/diff/24009/chrome/browser/printing/print_system_task_proxy.cc File chrome/browser/printing/print_system_task_proxy.cc (right): https://chromiumcodereview.appspot.com/10905006/diff/24009/chrome/browser/printing/print_system_task_proxy.cc#newcode10 ...
8 years, 3 months ago (2012-09-05 21:04:10 UTC) #8
Lei Zhang
https://chromiumcodereview.appspot.com/10905006/diff/29001/printing/backend/cups_helper.cc File printing/backend/cups_helper.cc (right): https://chromiumcodereview.appspot.com/10905006/diff/29001/printing/backend/cups_helper.cc#newcode287 printing/backend/cups_helper.cc:287: return (!((is_color_device && I think you need to get ...
8 years, 3 months ago (2012-09-05 21:10:15 UTC) #9
gene
https://chromiumcodereview.appspot.com/10905006/diff/29001/printing/backend/cups_helper.cc File printing/backend/cups_helper.cc (right): https://chromiumcodereview.appspot.com/10905006/diff/29001/printing/backend/cups_helper.cc#newcode287 printing/backend/cups_helper.cc:287: return (!((is_color_device && You are absolutely correct. Fixed. Thanks ...
8 years, 3 months ago (2012-09-05 21:15:10 UTC) #10
Lei Zhang
lgtm
8 years, 3 months ago (2012-09-05 21:16:06 UTC) #11
gene
Added more unittests. Found a bug. Unittests are great! Albert, can you take a look ...
8 years, 3 months ago (2012-09-06 17:21:13 UTC) #12
Albert Bodenhamer
lgtm
8 years, 3 months ago (2012-09-06 17:22:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10905006/20038
8 years, 3 months ago (2012-09-06 17:24:58 UTC) #14
commit-bot: I haz the power
Try job failure for 10905006-20038 (retry) on mac_rel for step "sync_integration_tests". It's a second try, ...
8 years, 3 months ago (2012-09-06 19:13:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10905006/20038
8 years, 3 months ago (2012-09-06 19:20:12 UTC) #16
commit-bot: I haz the power
Try job failure for 10905006-20038 (retry) on mac_rel for step "sync_integration_tests". It's a second try, ...
8 years, 3 months ago (2012-09-06 22:11:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10905006/20038
8 years, 3 months ago (2012-09-06 22:15:19 UTC) #18
commit-bot: I haz the power
Change committed as 155310
8 years, 3 months ago (2012-09-07 04:21:22 UTC) #19
Dan Beam
vivekg (from #chromium) and I both noticed this seems to break the compile on Linux ...
8 years, 3 months ago (2012-09-07 09:11:05 UTC) #20
gene1
8 years, 3 months ago (2012-09-07 17:52:52 UTC) #21
Damn, sorry about that :( (it failing on precise, correct?)
Fix is on it's way  http://codereview.chromium.org/10907108/

On Fri, Sep 7, 2012 at 2:11 AM, <dbeam@chromium.org> wrote:

> vivekg (from #chromium) and I both noticed this seems to break the compile
> on
> Linux with the follow error message - http://pastebin.com/raw.php?i=**
> kgAV7bR9 <http://pastebin.com/raw.php?i=kgAV7bR9>,
> btw
>
>
https://chromiumcodereview.**appspot.com/10905006/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698