chrome/browser/extensions/extension_icon_image.cc - Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_icon_image.cc

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: disable unittest on android Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action_icon_factory_unittest.cc ('k') | chrome/browser/extensions/extension_icon_image_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_icon_image.cc

diff --git a/chrome/browser/extensions/extension_icon_image.cc b/chrome/browser/extensions/extension_icon_image.cc

index 24125c40a51299bcc185219692b874e725ce1766..8259861f2fd4c068467fc5b865094c3483806408 100644

--- a/chrome/browser/extensions/extension_icon_image.cc

+++ b/chrome/browser/extensions/extension_icon_image.cc

@@ -193,7 +193,7 @@ gfx::ImageSkiaRep IconImage::LoadImageForScaleFactor(

std::vector<ImageLoadingTracker::ImageRepresentation> info_list;

info_list.push_back(ImageLoadingTracker::ImageRepresentation(

resource,

- ImageLoadingTracker::ImageRepresentation::RESIZE_WHEN_LARGER,

+ ImageLoadingTracker::ImageRepresentation::ALWAYS_RESIZE,

gfx::Size(resource_size_in_dip_, resource_size_in_dip_).Scale(scale),

scale_factor));

tracker_.LoadImages(extension_, info_list, ImageLoadingTracker::DONT_CACHE);