chrome/browser/extensions/api/extension_action/extension_actions_api.cc - Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review feedback Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/browser_action_apitest.cc ('k') | chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc » ('j') | chrome/common/extensions/extension_icon_factory_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

index 78a1815af961a2a4634ca560f2fe863649158e59..434112f3911089657d6b29622aae169f6610e45b 100644

--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

@@ -463,9 +463,7 @@ bool ExtensionActionSetIconFunction::RunExtensionAction() {

// set. Until we decide what to do with that, ignore.

if (!GetExtension()->page_action())

return true;

- if (icon_index < 0 ||

- static_cast<size_t>(icon_index) >=

- extension_action_->icon_paths()->size()) {

+ if (!extension_action_->IsValidIconIndex(icon_index)) {

error_ = kIconIndexOutOfBounds;

return false;

}