chrome/common/extensions/extension_icon_factory_delegate.h - Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/extension_icon_factory_delegate.h

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_ICON_FACTORY_DELEGATE_H_

	6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_ICON_FACTORY_DELEGATE_H_

	7

	8 #include "chrome/common/extensions/extension_icon_set.h"

	9

	10 namespace gfx {

	11 class ImageSkia;

	12 }

	13

	14 // Used by code living in chrome/common/ to delegate icon creation when the icon

	15 // creation cannot be done from chrome/common/ (e.g. if the icon is loaded

	16 // asynchronously using ImageLoadingTracker).

	17 class ExtensionIconFactoryDelegate {

	18 public:

	19 virtual ~ExtensionIconFactoryDelegate() {}

	20

	21 // Should create icon of desired size from icon paths defined in \|icon_set\|.

	22 virtual gfx::ImageSkia GetIcon(const ExtensionIconSet* icon_set,

	23 int desired_size) = 0;
	Jeffrey Yasskin 2012/09/13 00:23:36 Still trying to get my head around the meaning of Still trying to get my head around the meaning of this class ... I think what this does is provide a way to load an icon of a given gfx::Size-in-device-independent-pixels, given a set of icon paths for various scales. Is that correct? If so, please include that in the comments. I think it could make sense to pass gfx::Size instead of an int, even though all extension icons are currently square. Since these are paths and not pre-loaded images, any use of this class will require an observer, but the observer is hidden away in browser/ with no reference from here. It would be nice to make the returned object observable directly, but if that's infeasible, I'd like some place to document the overall arrangement of objects. tbarzic 2012/09/13 02:01:01 Done. Show quoted text On 2012/09/13 00:23:36, Jeffrey Yasskin wrote: > Still trying to get my head around the meaning of this class ... I think what > this does is provide a way to load an icon of a given > gfx::Size-in-device-independent-pixels, given a set of icon paths for various > scales. Is that correct? If so, please include that in the comments. I think it > could make sense to pass gfx::Size instead of an int, even though all extension > icons are currently square. > > Since these are paths and not pre-loaded images, any use of this class will > require an observer, but the observer is hidden away in browser/ with no > reference from here. It would be nice to make the returned object observable > directly, but if that's infeasible, I'd like some place to document the overall > arrangement of objects. Done.
	24 };

	25

	26 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_ICON_FACTORY_DELEGATE_H_

OLD	NEW