Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_browseraction_unittest.cc

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: minor cleanup Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6
7 #include "chrome/common/extensions/extension_action.h"
8 #include "chrome/common/extensions/extension_error_utils.h"
9 #include "chrome/common/extensions/extension_icon_set.h"
10 #include "chrome/common/extensions/extension_manifest_constants.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 namespace errors = extension_manifest_errors;
14
15 TEST_F(ExtensionManifestTest, BrowserActionManifestIcons) {
16 {
17 scoped_refptr<extensions::Extension> extension(
18 LoadAndExpectSuccess("browser_action_no_default_properties.json"));
19 ASSERT_TRUE(extension.get());
20 ASSERT_TRUE(extension->browser_action());
21 EXPECT_FALSE(extension->browser_action()->default_icon());
22 }
23
24 {
25 scoped_refptr<extensions::Extension> extension(
26 LoadAndExpectSuccess("browser_action_with_default_icon.json"));
27 ASSERT_TRUE(extension.get());
28 ASSERT_TRUE(extension->browser_action());
29 ASSERT_TRUE(extension->browser_action()->default_icon());
30
31 const ExtensionIconSet* icons = extension->browser_action()->default_icon();
32
33 EXPECT_EQ(1u, icons->map().size());
34 EXPECT_EQ("icon.png", icons->Get(19, ExtensionIconSet::MATCH_EXACTLY));
35 }
36
37 {
38 scoped_refptr<extensions::Extension> extension(
39 LoadAndExpectSuccess("browser_action_with_default_icon_set.json"));
40 ASSERT_TRUE(extension.get());
41 ASSERT_TRUE(extension->browser_action());
42 ASSERT_TRUE(extension->browser_action()->default_icon());
43
44 const ExtensionIconSet* icons = extension->browser_action()->default_icon();
45
46 EXPECT_EQ(2u, icons->map().size());
47 EXPECT_EQ("icon19.png", icons->Get(19, ExtensionIconSet::MATCH_EXACTLY));
48 EXPECT_EQ("icon38.png", icons->Get(38, ExtensionIconSet::MATCH_EXACTLY));
49 }
50
51 {
52 string16 error = ExtensionErrorUtils::FormatErrorMessageUTF16(
53 errors::kInvalidIconPath, "19");
54 LoadAndExpectError("browser_action_invalid_default_icons.json",
55 errors::kInvalidIconPath);
56 }
57 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698