Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: dbus/bus.cc

Issue 10900041: dbus: Fix clang warnings about missing virtual and OVERRIDE annotations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/bus.cc
diff --git a/dbus/bus.cc b/dbus/bus.cc
index 7a5d344a6cdb8ff94132cd8204c951d4b3fad4e2..73122c29dc38563e4c44fcc7eef9059538d7a751 100644
--- a/dbus/bus.cc
+++ b/dbus/bus.cc
@@ -33,7 +33,7 @@ class Watch : public base::MessagePumpLibevent::Watcher {
dbus_watch_set_data(raw_watch_, this, NULL);
}
- ~Watch() {
+ virtual ~Watch() {
dbus_watch_set_data(raw_watch_, NULL, NULL);
}
@@ -74,13 +74,13 @@ class Watch : public base::MessagePumpLibevent::Watcher {
private:
// Implement MessagePumpLibevent::Watcher.
- virtual void OnFileCanReadWithoutBlocking(int file_descriptor) {
+ virtual void OnFileCanReadWithoutBlocking(int file_descriptor) OVERRIDE {
const bool success = dbus_watch_handle(raw_watch_, DBUS_WATCH_READABLE);
CHECK(success) << "Unable to allocate memory";
}
// Implement MessagePumpLibevent::Watcher.
- virtual void OnFileCanWriteWithoutBlocking(int file_descriptor) {
+ virtual void OnFileCanWriteWithoutBlocking(int file_descriptor) OVERRIDE {
const bool success = dbus_watch_handle(raw_watch_, DBUS_WATCH_WRITABLE);
CHECK(success) << "Unable to allocate memory";
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698