Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: lib/compiler/implementation/universe.dart

Issue 10900023: A class can implement another class, so a selector on a class applies to a member that implements t… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/universe.dart
===================================================================
--- lib/compiler/implementation/universe.dart (revision 11507)
+++ lib/compiler/implementation/universe.dart (working copy)
@@ -375,8 +375,7 @@
}
ClassElement self = receiverType.element;
- // TODO(ngeoffray): tree-shake on interfaces.
- if (self.isInterface() || other.isSubclassOf(self)) {
+ if (other.implementsInterface(self) || other.isSubclassOf(self)) {
kasperl 2012/08/29 11:57:36 So this is essentially a subtype (not subclass) ch
ngeoffray 2012/08/29 12:13:50 It does. I added another test to make sure we don'
return appliesUntyped(element, compiler);
}
« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | tests/language/tree_shake_typed_selector_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698