Fix regression in BrowserThread's optimization of when it skips a lock. The variable name was misna…

content/browser/browser_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_thread_impl.h"
 
 #include <string>
 
 #include "base/atomicops.h"
 #include "base/bind.h"
@@ skipping 220 matching lines @@
     base::TimeDelta delay,
     bool nestable) {
   DCHECK(identifier >= 0 && identifier < ID_COUNT);
   // Optimization: to avoid unnecessary locks, we listed the ID enumeration in
   // order of lifetime.  So no need to lock if we know that the other thread
   // outlives this one.
   // Note: since the array is so small, ok to loop instead of creating a map,
   // which would require a lock because std::map isn't thread safe, defeating
   // the whole purpose of this optimization.
   BrowserThread::ID current_thread;
-  bool guaranteed_to_outlive_target_thread =
+  bool target_thread_outlives_current =
       GetCurrentThreadIdentifier(&current_thread) &&
-      current_thread <= identifier;
+      current_thread >= identifier;
 
   BrowserThreadGlobals& globals = g_globals.Get();
-  if (!guaranteed_to_outlive_target_thread)
+  if (!target_thread_outlives_current)
     globals.lock.Acquire();
 
   MessageLoop* message_loop = globals.threads[identifier] ?
       globals.threads[identifier]->message_loop() : NULL;
   if (message_loop) {
     if (nestable) {
       message_loop->PostDelayedTask(from_here, task, delay);
     } else {
       message_loop->PostNonNestableDelayedTask(from_here, task, delay);
     }
   }
 
-  if (!guaranteed_to_outlive_target_thread)
+  if (!target_thread_outlives_current)
     globals.lock.Release();
 
   return !!message_loop;
 }
 
 // An implementation of MessageLoopProxy to be used in conjunction
 // with BrowserThread.
 class BrowserThreadMessageLoopProxy : public base::MessageLoopProxy {
  public:
   explicit BrowserThreadMessageLoopProxy(BrowserThread::ID identifier)
@@ skipping 193 matching lines @@
   AtomicWord* storage = reinterpret_cast<AtomicWord*>(
       &globals.thread_delegates[identifier]);
   AtomicWord old_pointer = base::subtle::NoBarrier_AtomicExchange(
       storage, reinterpret_cast<AtomicWord>(delegate));
 
   // This catches registration when previously registered.
   DCHECK(!delegate || !old_pointer);
 }
 
 }  // namespace content