Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10899041: Add additional debug/check for ScopedCOMInitializer. (Closed)

Created:
8 years, 3 months ago by arthurhsu
Modified:
8 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add additional debug/check for ScopedCOMInitializer. BUG=145095 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M base/win/scoped_com_initializer.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
arthurhsu
8 years, 3 months ago (2012-08-29 20:05:30 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
8 years, 3 months ago (2012-08-30 00:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arthurhsu@chromium.org/10899041/1
8 years, 3 months ago (2012-08-30 00:57:37 UTC) #3
commit-bot: I haz the power
Presubmit check for 10899041-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-30 00:57:39 UTC) #4
arthurhsu
+brettw for OWNER review
8 years, 3 months ago (2012-08-30 00:59:58 UTC) #5
brettw
lgtm
8 years, 3 months ago (2012-08-30 05:34:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arthurhsu@chromium.org/10899041/1
8 years, 3 months ago (2012-08-30 16:42:41 UTC) #7
commit-bot: I haz the power
Try job failure for 10899041-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 19:37:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arthurhsu@chromium.org/10899041/1
8 years, 3 months ago (2012-08-30 20:52:07 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 23:38:09 UTC) #10 
Change committed as 154312

Powered by Google App Engine
This is Rietveld 408576698