Refactoring bluetooth API code.

chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_BLUETOOTH_OPTIONS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_BLUETOOTH_OPTIONS_HANDLER_H_
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
-#include "chrome/browser/chromeos/bluetooth/bluetooth_adapter.h"
-#include "chrome/browser/chromeos/bluetooth/bluetooth_device.h"
+#include "chrome/browser/chromeos/bluetooth/bluetooth_adapter_dbus.h"

[bryeung, 2012/09/07 18:35:57]

should be using the interface

[youngki, 2012/09/13 18:05:02]

Done.

+#include "chrome/browser/chromeos/bluetooth/bluetooth_device_dbus.h"
 #include "chrome/browser/ui/webui/options/options_ui.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace chromeos {
 namespace options {
 
 // Handler for Bluetooth options on the system options page.
-class BluetoothOptionsHandler : public ::options::OptionsPageUIHandler,
-                                public chromeos::BluetoothAdapter::Observer,
-                                public BluetoothDevice::PairingDelegate {
+class BluetoothOptionsHandler
+    : public ::options::OptionsPageUIHandler,
+      public chromeos::BluetoothAdapterDBus::Observer,
+      public BluetoothDeviceDBus::PairingDelegate {
  public:
   BluetoothOptionsHandler();
   virtual ~BluetoothOptionsHandler();
 
   // OptionsPageUIHandler implementation.
   virtual void GetLocalizedValues(
       base::DictionaryValue* localized_strings) OVERRIDE;
   virtual void RegisterMessages() OVERRIDE;
   virtual void InitializeHandler() OVERRIDE;
   virtual void InitializePage() OVERRIDE;
 
   // Sends a notification to the Web UI of the status of a Bluetooth device.
   // |device| is the Bluetooth device.
   // |params| is an optional set of parameters.
-  void SendDeviceNotification(const BluetoothDevice* device,
+  void SendDeviceNotification(const BluetoothDeviceInterface* device,
                               base::DictionaryValue* params);
 
-  // BluetoothDevice::PairingDelegate override.
+  // BluetoothDeviceDBus::PairingDelegate override.
   //
   // This method will be called when the Bluetooth daemon requires a
   // PIN Code for authentication of the device |device|, the UI will display
   // a blank entry form to obtain the PIN code from the user.
   //
   // PIN Codes are generally required for Bluetooth 2.0 and earlier devices
   // for which there is no automatic pairing or special handling.
-  virtual void RequestPinCode(BluetoothDevice* device) OVERRIDE;
+  virtual void RequestPinCode(BluetoothDeviceDBus* device) OVERRIDE;
 
-  // BluetoothDevice::PairingDelegate override.
+  // BluetoothDeviceDBus::PairingDelegate override.
   //
   // This method will be called when the Bluetooth daemon requires a
   // Passkey for authentication of the device |device|, the UI will display
   // a blank entry form to obtain the passkey from the user (a numeric in the
   // range 0-999999).
   //
   // Passkeys are generally required for Bluetooth 2.1 and later devices
   // which cannot provide input or display on their own, and don't accept
   // passkey-less pairing.
-  virtual void RequestPasskey(BluetoothDevice* device) OVERRIDE;
+  virtual void RequestPasskey(BluetoothDeviceDBus* device) OVERRIDE;
 
-  // BluetoothDevice::PairingDelegate override.
+  // BluetoothDeviceDBus::PairingDelegate override.
   //
   // This method will be called when the Bluetooth daemon requires that the
   // user enter the PIN code |pincode| into the device |device| so that it
   // may be authenticated, the UI will display the PIN code with accompanying
   // instructions.
   //
   // This is used for Bluetooth 2.0 and earlier keyboard devices, the
   // |pincode| will always be a six-digit numeric in the range 000000-999999
   // for compatibilty with later specifications.
-  virtual void DisplayPinCode(BluetoothDevice* device,
+  virtual void DisplayPinCode(BluetoothDeviceDBus* device,
                               const std::string& pincode) OVERRIDE;
 
-  // BluetoothDevice::PairingDelegate override.
+  // BluetoothDeviceDBus::PairingDelegate override.
   //
   // This method will be called when the Bluetooth daemon requires that the
   // user enter the Passkey |passkey| into the device |device| so that it
   // may be authenticated, the UI will display the passkey with accompanying
   // instructions.
   //
   // This is used for Bluetooth 2.1 and later devices that support input
   // but not display, such as keyboards. The Passkey is a numeric in the
   // range 0-999999 and should be always presented zero-padded to six
   // digits.
-  virtual void DisplayPasskey(BluetoothDevice* device,
+  virtual void DisplayPasskey(BluetoothDeviceDBus* device,
                               uint32 passkey) OVERRIDE;
 
-  // BluetoothDevice::PairingDelegate override.
+  // BluetoothDeviceDBus::PairingDelegate override.
   //
   // This method will be called when the Bluetooth daemon requires that the
   // user confirm that the Passkey |passkey| is displayed on the screen
   // of the device |device| so that it may be authenticated, the UI will
   // display the passkey with accompanying instructions.
   //
   // This is used for Bluetooth 2.1 and later devices that support display,
   // such as other computers or phones. The Passkey is a numeric in the
   // range 0-999999 and should be always present zero-padded to six
   // digits.
-  virtual void ConfirmPasskey(BluetoothDevice* device,
+  virtual void ConfirmPasskey(BluetoothDeviceDBus* device,
                               uint32 passkey) OVERRIDE;
 
-  // BluetoothDevice::PairingDelegate override.
+  // BluetoothDeviceDBus::PairingDelegate override.
   //
   // This method will be called when any previous DisplayPinCode(),
   // DisplayPasskey() or ConfirmPasskey() request should be concluded
   // and removed from the user.
   virtual void DismissDisplayOrConfirm() OVERRIDE;
 
   // Displays a Bluetooth error.
   // |error| maps to a localized resource for the error message.
   // |address| is the address of the Bluetooth device.  May be an empty
   // string if the error is not specific to a single device.
   void ReportError(const std::string& error, const std::string& address);
 
-  // BluetoothAdapter::Observer implementation.
-  virtual void AdapterPresentChanged(BluetoothAdapter* adapter,
+  // BluetoothAdapterDBus::Observer implementation.
+  virtual void AdapterPresentChanged(BluetoothAdapterDBus* adapter,
                                      bool present) OVERRIDE;
-  virtual void AdapterPoweredChanged(BluetoothAdapter* adapter,
+  virtual void AdapterPoweredChanged(BluetoothAdapterDBus* adapter,
                                      bool powered) OVERRIDE;
-  virtual void DeviceAdded(BluetoothAdapter* adapter,
-                           BluetoothDevice* device) OVERRIDE;
-  virtual void DeviceChanged(BluetoothAdapter* adapter,
-                             BluetoothDevice* device) OVERRIDE;
-  virtual void DeviceRemoved(BluetoothAdapter* adapter,
-                             BluetoothDevice* device) OVERRIDE;
+  virtual void DeviceAdded(BluetoothAdapterDBus* adapter,
+                           BluetoothDeviceDBus* device) OVERRIDE;
+  virtual void DeviceChanged(BluetoothAdapterDBus* adapter,
+                             BluetoothDeviceDBus* device) OVERRIDE;
+  virtual void DeviceRemoved(BluetoothAdapterDBus* adapter,
+                             BluetoothDeviceDBus* device) OVERRIDE;
 
  private:
-  // Called by BluetoothAdapter in response to a failure to change the
+  // Called by BluetoothAdapterDBus in response to a failure to change the
   // power status of the adapter.
   void EnableChangeError();
 
-  // Called by BluetoothAdapter in response to a failure to set the adapter
+  // Called by BluetoothAdapterDBus in response to a failure to set the adapter
   // into discovery mode.
   void FindDevicesError();
 
-  // Called by BluetoothAdapter in response to a failure to remove the adapter
-  // from discovery mode.
+  // Called by BluetoothAdapterDBus in response to a failure to remove the
+  // adapter from discovery mode.
   void StopDiscoveryError();
 
-  // Called by BluetoothDevice in response to a failure to connect to the
+  // Called by BluetoothDeviceDBus in response to a failure to connect to the
   // device with bluetooth address |address|.
   void ConnectError(const std::string& address);
 
-  // Called by BluetoothDevice in response to a failure to disconnect the
+  // Called by BluetoothDeviceDBus in response to a failure to disconnect the
   // device with bluetooth address |address|.
   void DisconnectError(const std::string& address);
 
-  // Called by BluetoothDevice in response to a failure to disconnect and
+  // Called by BluetoothDeviceDBus in response to a failure to disconnect and
   // unpair the device with bluetooth address |address|.
   void ForgetError(const std::string& address);
 
   // Called when the 'Enable bluetooth' checkbox value is changed.
   // |args| will contain the checkbox checked state as a string
   // ("true" or "false").
   void EnableChangeCallback(const base::ListValue* args);
 
   // Called when the 'Find Devices' button is pressed from the Bluetooth
   // ssettings.
@@ skipping 11 matching lines @@
   // process.
   // |args| will be an empty list.
   void StopDiscoveryCallback(const base::ListValue* args);
 
   // Called when the list of paired devices is initialized in order to
   // populate the list.
   // |args| will be an empty list.
   void GetPairedDevicesCallback(const base::ListValue* args);
 
   // Default bluetooth adapter, used for all operations.
-  scoped_refptr<BluetoothAdapter> adapter_;
+  scoped_refptr<BluetoothAdapterDBus> adapter_;
 
   // Weak pointer factory for generating 'this' pointers that might live longer
   // than this object does.
   base::WeakPtrFactory<BluetoothOptionsHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothOptionsHandler);
 };
 
 }  // namespace options
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_BLUETOOTH_OPTIONS_HANDLER_H_