Fix assets related to ev bubble and tab to search UI elements.

Switch to new assets and fix corresponding constants related to ev bubble, tab to search UI elements and the content settings bubble. Assets checked in in http://codereview.chromium.org/10896009/

BUG=137351, 137717
TEST=manual: To test EV bubble, invoke it in the omnibox by going to paypal.com. The bubble should be completely inside the omnibox with one pixel padding on top and bottom. Same checks for tab-to-search bubble and content setting bubble.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154144

[Peter Kasting, 2012-08-28 23:22:48]

LGTM, make sure to delete the old unreferenced images after checking this in

https://chromiumcodereview.appspot.com/10899009/diff/7004/chrome/browser/ui/v...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://chromiumcodereview.appspot.com/10899009/diff/7004/chrome/browser/ui/v...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:223:
views::Border* empty_border = views::Border::CreateEmptyBorder(
Nit: Wrap after = instead

https://chromiumcodereview.appspot.com/10899009/diff/7004/chrome/browser/ui/v...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:232:
GetImageBounds().right() + kTextMarginPixels, 0,
Nit: Shouldn't leaving this as "y()" still work?  It seems slightly better.

[varunjain, 2012-08-29 02:59:57]

https://chromiumcodereview.appspot.com/10899009/diff/7004/chrome/browser/ui/v...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://chromiumcodereview.appspot.com/10899009/diff/7004/chrome/browser/ui/v...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:223:
views::Border* empty_border = views::Border::CreateEmptyBorder(
On 2012/08/28 23:22:48, Peter Kasting wrote:
> Nit: Wrap after = instead

Done.

https://chromiumcodereview.appspot.com/10899009/diff/7004/chrome/browser/ui/v...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:232:
GetImageBounds().right() + kTextMarginPixels, 0,
On 2012/08/28 23:22:48, Peter Kasting wrote:
> Nit: Shouldn't leaving this as "y()" still work?  It seems slightly better.

I am not sure if y() is even correct. It give the y-coordinate of the
ContentSettingImageView. Why should the string be drawn at the y-coordinate of
the view? Keeping it 0 makes sense because the TEXT_VALIGN_MIDDLE flag will draw
the string vertically in the middle of the rect.

[Peter Kasting, 2012-08-29 21:35:14]

https://chromiumcodereview.appspot.com/10899009/diff/7004/chrome/browser/ui/v...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://chromiumcodereview.appspot.com/10899009/diff/7004/chrome/browser/ui/v...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:232:
GetImageBounds().right() + kTextMarginPixels, 0,
On 2012/08/29 02:59:57, varunjain wrote:
> On 2012/08/28 23:22:48, Peter Kasting wrote:
> > Nit: Shouldn't leaving this as "y()" still work?  It seems slightly better.
> 
> I am not sure if y() is even correct. It give the y-coordinate of the
> ContentSettingImageView. Why should the string be drawn at the y-coordinate of
> the view? Keeping it 0 makes sense because the TEXT_VALIGN_MIDDLE flag will
draw
> the string vertically in the middle of the rect.

I think you're correct, the coordinates used here ought to be relative to the
local bounds, not relative to the parent bounds.

[sail, 2012-08-29 22:51:49]

CL description needs to be expanded.
"fix assets" is vague
no idea what an "ev bubble", or "cs bubble" is
TEST=manual is useless. Can you describe how to invoke this code. How can
someone tell if this is working or broken?

[varunjain, 2012-08-29 22:56:55]

On 2012/08/29 22:51:49, sail wrote:
> CL description needs to be expanded.
> "fix assets" is vague
> no idea what an "ev bubble", or "cs bubble" is
> TEST=manual is useless. Can you describe how to invoke this code. How can
> someone tell if this is working or broken?

Done.

[sail, 2012-08-29 23:00:21]

Instead of "site with security certification" just put a link.
Link to CL where the images were added is still not in the CL description.

[sail, 2012-08-29 23:03:53]

lgtm

[commit-bot: I haz the power, 2012-08-30 04:28:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/10899009/17001

[commit-bot: I haz the power, 2012-08-30 05:49:30]

Try job failure for 10899009-17001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-30 10:35:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/10899009/17001

[commit-bot: I haz the power, 2012-08-30 14:45:58]

Change committed as 154144