Set component=static_library for ASan builds on Mac.

Set component=static_library for ASan builds on Mac.

BUG=145503
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153911

[Alexander Potapenko, 2012-08-29 17:19:20]

PTAL

[Nico, 2012-08-29 17:22:39]

https://chromiumcodereview.appspot.com/10898037/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10898037/diff/1/build/common.gypi#newc...
build/common.gypi:1210: 'component%': "static_library",
The trailing % means it's overridable.
tools/build/scripts/master/factory/chromium_factory.py sets
component=shared_library for debug bots, so I think this wouldn't have any
effect there.

Making this not overridable doesn't sound great either though :-(

[Alexander Potapenko, 2012-08-29 17:26:11]

> build/common.gypi:1210: 'component%': "static_library",
> The trailing % means it's overridable.
TIL++

> tools/build/scripts/master/factory/chromium_factory.py sets
> component=shared_library for debug bots, so I think this wouldn't have any
> effect there.
Yes, you're right 
> Making this not overridable doesn't sound great either though :-(
Why? Looks like it disallows overriding static with shared -- isn't that what we
want?

[Nico, 2012-08-29 17:28:29]

On 2012/08/29 17:26:11, Alexander Potapenko wrote:
> > build/common.gypi:1210: 'component%': "static_library",
> > The trailing % means it's overridable.
> TIL++
> 
> > tools/build/scripts/master/factory/chromium_factory.py sets
> > component=shared_library for debug bots, so I think this wouldn't have any
> > effect there.
> Yes, you're right 
> > Making this not overridable doesn't sound great either though :-(
> Why? Looks like it disallows overriding static with shared -- isn't that what
we
> want?

I was thinking it makes it harder for people working on asan (== you) to test
with a components build, but I think having this patch in is better than not
having it.

LGTM if you have checked that `GYP_DEFINES="asan=1 component=shared_library"`
does in fact produce a static library build after this patch.

[Alexander Potapenko, 2012-08-29 17:47:42]

> LGTM if you have checked that `GYP_DEFINES="asan=1 component=shared_library"`
> does in fact produce a static library build after this patch.
Done