Disallow NaCl in chrome webstore for ARM

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 168a585aa14394aa6a8224d3795d4567f92bebda..e4e47f2967ef3cd062f93f1b662e6e95e16d5b0b 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -605,11 +605,17 @@ bool ChromeContentRendererClient::IsNaClAllowed(
   // Allow Chrome Web Store extensions, built-in extensions, extensions
   // under development, invocations from whitelisted URLs, and all invocations
   // if --enable-nacl is set.
+#ifdef __arm__

[jvoung (off chromium), 2012/08/29 16:49:33]

nit: not sure if the if-defs are usually ARCH_CPU_ARM_FAMILY or __arm__ in
chrome code (lot of third_party uses __arm__, while base/ uses the other...)

[Derek Schuff, 2012/08/29 17:00:25]

Yeah, I wasn't sure either. I found both sprinkled in various places throughout
the chrome code (and both in content/ and chrome/), but more uses of __arm__ so
I went with that.
On 2012/08/29 16:49:33, jvoung (chromium) wrote:

+  // Since the ARM ABI is not quite stable, do not allow webstore extensions
+  // to use it yet. TODO(dschuff): remove this when the ABI is stable
+  bool is_nacl_allowed = is_extension_unrestricted || is_nacl_unrestricted;

[jvoung (off chromium), 2012/08/29 16:49:33]

Just to confirm, some of the apps we are interested in testing are
Component/Load ones, and don't require other whitelisting?

[Derek Schuff, 2012/08/29 17:00:25]

Right. If you look directly above the only whitelisted URLs are
plus.google.com/games. So unless I hear specifically about them, they will be
blocked.
On 2012/08/29 16:49:33, jvoung (chromium) wrote:

+#else
   bool is_nacl_allowed =
       is_extension_from_webstore ||
       is_extension_unrestricted ||
       is_whitelisted_url ||
       is_nacl_unrestricted;
+#endif
   if (is_nacl_allowed) {
     bool app_can_use_dev_interfaces =
         // NaCl PDF viewer extension