Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10898007: Forget about DesktopBackgroundWidget if it was deleted (Closed)

Created:
8 years, 3 months ago by Denis Kuznetsov (DE-MUC)
Modified:
8 years, 3 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Forget about DesktopBackgroundView if it was deleted BUG=144047, 145595 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154611

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix nits #

Patch Set 3 : Additional check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M ash/desktop_background/desktop_background_controller.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 2 chunks +39 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Denis Kuznetsov (DE-MUC)
8 years, 3 months ago (2012-08-28 16:00:23 UTC) #1
Nikita (slow)
lgtm https://chromiumcodereview.appspot.com/10898007/diff/1/ash/desktop_background/desktop_background_controller.h File ash/desktop_background/desktop_background_controller.h (right): https://chromiumcodereview.appspot.com/10898007/diff/1/ash/desktop_background/desktop_background_controller.h#newcode121 ash/desktop_background/desktop_background_controller.h:121: void CleanUpView(aura::RootWindow* root_window); nit: Cleanup https://chromiumcodereview.appspot.com/10898007/diff/1/ash/desktop_background/desktop_background_view.cc File ash/desktop_background/desktop_background_view.cc ...
8 years, 3 months ago (2012-08-28 17:42:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/10898007/8001
8 years, 3 months ago (2012-08-30 12:47:12 UTC) #3
commit-bot: I haz the power
Try job failure for 10898007-8001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 14:42:45 UTC) #4
Nikita (slow)
Retry commit?
8 years, 3 months ago (2012-08-31 17:00:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/10898007/18001
8 years, 3 months ago (2012-09-01 05:36:02 UTC) #6
commit-bot: I haz the power
Change committed as 154611
8 years, 3 months ago (2012-09-01 09:51:27 UTC) #7
Mattias Nissler (ping if slow)
On 2012/09/01 09:51:27, I haz the power (commit-bot) wrote: > Change committed as 154611 This ...
8 years, 3 months ago (2012-09-01 11:18:17 UTC) #8
Nikita (slow)
Revert: https://chromiumcodereview.appspot.com/10915046/
8 years, 3 months ago (2012-09-03 09:19:06 UTC) #9
Nikita (slow)
8 years, 3 months ago (2012-09-03 09:20:02 UTC) #10 
On 2012/09/01 11:18:17, Mattias Nissler wrote:
> On 2012/09/01 09:51:27, I haz the power (commit-bot) wrote:
> > Change committed as 154611
> 
> This caused compile failures on the waterfall, I'm going to revert.

Any links to the bots? What types of bots were failing? I guess smth  like
win_aura

Powered by Google App Engine
This is Rietveld 408576698