Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: tests/corelib/const_list_literal_test.dart

Issue 10898003: Remove List.copyFrom from VM and from tests. It was removed from the List interface in r941. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment, fix error. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/co19/co19-runtime.status ('k') | tests/corelib/growable_object_array2_vm_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // Test that a final list literal is not expandable nor modifiable. 5 // Test that a final list literal is not expandable nor modifiable.
6 6
7 class ConstListLiteralTest { 7 class ConstListLiteralTest {
8 8
9 static void testMain() { 9 static void testMain() {
10 var list = const [4, 2, 3]; 10 var list = const [4, 2, 3];
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 exception = e; 45 exception = e;
46 } 46 }
47 Expect.equals(true, exception != null); 47 Expect.equals(true, exception != null);
48 Expect.equals(3, list.length); 48 Expect.equals(3, list.length);
49 Expect.equals(4, list[0]); 49 Expect.equals(4, list[0]);
50 Expect.equals(2, list[1]); 50 Expect.equals(2, list[1]);
51 Expect.equals(3, list[2]); 51 Expect.equals(3, list[2]);
52 52
53 exception = null; 53 exception = null;
54 try { 54 try {
55 list.copyFrom([1], 0, 0, 1); 55 list.setRange(0, 1, [1], 0);
56 } catch (NoSuchMethodException e) {
57 // TODO(ahe): While we are resolving CL 9839101, we have two
58 // cases: the VMs implementation class has a method named
59 // copyFrom, dart2js does not.
60 exception = e;
61 } catch (UnsupportedOperationException e) { 56 } catch (UnsupportedOperationException e) {
62 exception = e; 57 exception = e;
63 } 58 }
64 Expect.equals(true, exception != null); 59 Expect.equals(true, exception != null);
65 Expect.equals(3, list.length); 60 Expect.equals(3, list.length);
66 Expect.equals(4, list[0]); 61 Expect.equals(4, list[0]);
67 Expect.equals(2, list[1]); 62 Expect.equals(2, list[1]);
68 Expect.equals(3, list[2]); 63 Expect.equals(3, list[2]);
69 64
70 // Note: the next check is a regression test for dart2js. The immutable list 65 // Note: the next check is a regression test for dart2js. The immutable list
71 // overrides the 'length' property of List, but relies on using the native 66 // overrides the 'length' property of List, but relies on using the native
72 // 'forEach' construct in Array. This test ensures that our strategy works 67 // 'forEach' construct in Array. This test ensures that our strategy works
73 // correctly. 68 // correctly.
74 int x = 0; 69 int x = 0;
75 list.forEach((e) { x += e; }); 70 list.forEach((e) { x += e; });
76 Expect.equals(9, x); 71 Expect.equals(9, x);
77 } 72 }
78 } 73 }
79 74
80 main() { 75 main() {
81 ConstListLiteralTest.testMain(); 76 ConstListLiteralTest.testMain();
82 } 77 }
OLDNEW
« no previous file with comments | « tests/co19/co19-runtime.status ('k') | tests/corelib/growable_object_array2_vm_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698