chrome/browser/automation/automation_provider.cc - Issue 10898002: Refactor BrowsingDataRemover creation for clarity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 10898002: Refactor BrowsingDataRemover creation for clarity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Feedback, round 1. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/automation_provider.cc

diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc

index 35e2ca4d2383cb59cb75dc732470fd8eec2eae57..4d58eda770c615ca06f0beb4013cacd4340e1f09 100644

--- a/chrome/browser/automation/automation_provider.cc

+++ b/chrome/browser/automation/automation_provider.cc

@@ -674,9 +674,7 @@ void AutomationProvider::OnSetPageFontSize(int tab_handle,

void AutomationProvider::RemoveBrowsingData(int remove_mask) {

BrowsingDataRemover* remover;

- remover = new BrowsingDataRemover(profile(),

- BrowsingDataRemover::EVERYTHING, // All time periods.

- base::Time());

+ remover = BrowsingDataRemover::CreateForUnboundedRange(profile());

remover->Remove(remove_mask, BrowsingDataHelper::UNPROTECTED_WEB);

// BrowsingDataRemover deletes itself.

}