Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 10898002: Refactor BrowsingDataRemover creation for clarity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Markus' feedback. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h" 5 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1084 matching lines...) Expand 10 before | Expand all | Expand 10 after
1095 base::Bind(&SigninScreenHandler::OnDnsCleared, 1095 base::Bind(&SigninScreenHandler::OnDnsCleared,
1096 weak_factory_.GetWeakPtr())); 1096 weak_factory_.GetWeakPtr()));
1097 dns_clear_task_running_ = true; 1097 dns_clear_task_running_ = true;
1098 } 1098 }
1099 1099
1100 void SigninScreenHandler::StartClearingCookies() { 1100 void SigninScreenHandler::StartClearingCookies() {
1101 cookies_cleared_ = false; 1101 cookies_cleared_ = false;
1102 if (cookie_remover_) 1102 if (cookie_remover_)
1103 cookie_remover_->RemoveObserver(this); 1103 cookie_remover_->RemoveObserver(this);
1104 1104
1105 cookie_remover_ = new BrowsingDataRemover( 1105 cookie_remover_ = BrowsingDataRemover::CreateForUnboundedRange(
1106 Profile::FromWebUI(web_ui()), 1106 Profile::FromWebUI(web_ui()));
1107 BrowsingDataRemover::EVERYTHING,
1108 base::Time::Now());
1109 cookie_remover_->AddObserver(this); 1107 cookie_remover_->AddObserver(this);
1110 cookie_remover_->Remove(BrowsingDataRemover::REMOVE_SITE_DATA, 1108 cookie_remover_->Remove(BrowsingDataRemover::REMOVE_SITE_DATA,
1111 BrowsingDataHelper::UNPROTECTED_WEB); 1109 BrowsingDataHelper::UNPROTECTED_WEB);
1112 } 1110 }
1113 1111
1114 void SigninScreenHandler::MaybePreloadAuthExtension() { 1112 void SigninScreenHandler::MaybePreloadAuthExtension() {
1115 // Fetching of the extension is not started before account picker page is 1113 // Fetching of the extension is not started before account picker page is
1116 // loaded because it can affect the loading speed. Also if |cookie_remover_| 1114 // loaded because it can affect the loading speed. Also if |cookie_remover_|
1117 // or |dns_clear_task_running_| then auth extension showing has already been 1115 // or |dns_clear_task_running_| then auth extension showing has already been
1118 // initiated and preloading is senseless. 1116 // initiated and preloading is senseless.
(...skipping 28 matching lines...) Expand all
1147 } 1145 }
1148 for (UserList::const_iterator it = users.begin(); it != users.end(); ++it) { 1146 for (UserList::const_iterator it = users.begin(); it != users.end(); ++it) {
1149 if (!cros_settings->FindEmailInList(kAccountsPrefUsers, (*it)->email())) { 1147 if (!cros_settings->FindEmailInList(kAccountsPrefUsers, (*it)->email())) {
1150 return false; 1148 return false;
1151 } 1149 }
1152 } 1150 }
1153 return true; 1151 return true;
1154 } 1152 }
1155 1153
1156 } // namespace chromeos 1154 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698