Relanding "views: Add a gyp file to build webview."

Relanding "views: Add a gyp file to build webview."

This reverts commit 819e83e11f734af26da7c0de8c2b0316a35516dc. Revision 153817.

BUG=105557
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154048

[tfarina, 2012-08-30 02:16:12]

TBRing...

[not at google - send to devlin, 2012-08-30 05:34:27]

E.g.

Compiling...
webview.cc
Linking...
   Creating library ..\..\..\..\build\Debug\\lib\webview.lib and object
..\..\..\..\build\Debug\\lib\webview.exp
webview.obj :error LNK2019: unresolved external symbol "__declspec(dllimport)
bool __cdecl base::i18n::IsRTL(void)" (__imp_?IsRTL@i18n@base@@YA_NXZ)
referenced in function "public: bool __thiscall
views::View::FlipCanvasOnPaintForRTLUI(void)const "
(?FlipCanvasOnPaintForRTLUI@View@views@@QBE_NXZ)
webview.obj :error LNK2019: unresolved external symbol "private: static bool
views::FocusManager::shortcut_handling_suspended_"
(?shortcut_handling_suspended_@FocusManager@views@@0_NA) referenced in function
"public: static void __cdecl
views::FocusManager::set_shortcut_handling_suspended(bool)"
(?set_shortcut_handling_suspended@FocusManager@views@@SAX_N@Z)
webview.obj :error LNK2019: unresolved external symbol "public: static class
views::ViewsDelegate * views::ViewsDelegate::views_delegate"
(?views_delegate@ViewsDelegate@views@@2PAV12@A) referenced in function "private:
class content::WebContents * __thiscall views::WebView::CreateWebContents(class
content::BrowserContext *,class content::SiteInstance *)"
(?CreateWebContents@WebView@views@@AAEPAVWebContents@content@@PAVBrowserContext@4@PAVSiteInstance@4@@Z)
..\..\..\..\build\Debug\\webview.dll : fatalerror LNK1120: 3 unresolved
externals

[tfarina, 2012-08-30 10:43:43]

On Thursday, August 30, 2012, wrote:

> E.g.
>
> Compiling...
> webview.cc
> Linking...
>    Creating library ..\..\..\..\build\Debug\\lib\**webview.lib and object
> ..\..\..\..\build\Debug\\lib\**webview.exp
> webview.obj :error LNK2019: unresolved external symbol
> "__declspec(dllimport)
> bool __cdecl base::i18n::IsRTL(void)" (__imp_?IsRTL@i18n@base@@YA_**NXZ)
> referenced in function "public: bool __thiscall
> views::View::**FlipCanvasOnPaintForRTLUI(**void)const "
> (?FlipCanvasOnPaintForRTLUI@**View@views@@QBE_NXZ)
> webview.obj :error LNK2019: unresolved external symbol "private: static
> bool
> views::FocusManager::shortcut_**handling_suspended_"
> (?shortcut_handling_suspended_**@FocusManager@views@@0_NA) referenced in
> function
> "public: static void __cdecl
> views::FocusManager::set_**shortcut_handling_suspended(**bool)"
> (?set_shortcut_handling_**suspended@FocusManager@views@@**SAX_N@Z)
> webview.obj :error LNK2019: unresolved external symbol "public: static
> class
> views::ViewsDelegate * views::ViewsDelegate::views_**delegate"
> (?views_delegate@ViewsDelegate**@views@@2PAV12@A) referenced in function
> "private:
> class content::WebContents * __thiscall views::WebView::**
> CreateWebContents(class
> content::BrowserContext *,class content::SiteInstance *)"
> (?CreateWebContents@WebView@**views@@AAEPAVWebContents@**content@
> @PAVBrowserContext@4@**PAVSiteInstance@4@@Z)
> ..\..\..\..\build\Debug\\**webview.dll : fatalerror LNK1120: 3 unresolved
> externals
>
> Which fuk...win trybot has this configuration that I should try?

It passes win_rel so  win_rel does not build a shared_library.

Looks like this is missing base_i18n dep

I'll try once more making sure it passes the RIGHT win trybot!!


>
https://chromiumcodereview.**appspot.com/10897037/<https://chromiumcodereview...
>


-- 
Thiago

[tfarina, 2012-08-30 10:43:43]

On Thursday, August 30, 2012, wrote:

> E.g.
>
> Compiling...
> webview.cc
> Linking...
>    Creating library ..\..\..\..\build\Debug\\lib\**webview.lib and object
> ..\..\..\..\build\Debug\\lib\**webview.exp
> webview.obj :error LNK2019: unresolved external symbol
> "__declspec(dllimport)
> bool __cdecl base::i18n::IsRTL(void)" (__imp_?IsRTL@i18n@base@@YA_**NXZ)
> referenced in function "public: bool __thiscall
> views::View::**FlipCanvasOnPaintForRTLUI(**void)const "
> (?FlipCanvasOnPaintForRTLUI@**View@views@@QBE_NXZ)
> webview.obj :error LNK2019: unresolved external symbol "private: static
> bool
> views::FocusManager::shortcut_**handling_suspended_"
> (?shortcut_handling_suspended_**@FocusManager@views@@0_NA) referenced in
> function
> "public: static void __cdecl
> views::FocusManager::set_**shortcut_handling_suspended(**bool)"
> (?set_shortcut_handling_**suspended@FocusManager@views@@**SAX_N@Z)
> webview.obj :error LNK2019: unresolved external symbol "public: static
> class
> views::ViewsDelegate * views::ViewsDelegate::views_**delegate"
> (?views_delegate@ViewsDelegate**@views@@2PAV12@A) referenced in function
> "private:
> class content::WebContents * __thiscall views::WebView::**
> CreateWebContents(class
> content::BrowserContext *,class content::SiteInstance *)"
> (?CreateWebContents@WebView@**views@@AAEPAVWebContents@**content@
> @PAVBrowserContext@4@**PAVSiteInstance@4@@Z)
> ..\..\..\..\build\Debug\\**webview.dll : fatalerror LNK1120: 3 unresolved
> externals
>
> Which fuk...win trybot has this configuration that I should try?

It passes win_rel so  win_rel does not build a shared_library.

Looks like this is missing base_i18n dep

I'll try once more making sure it passes the RIGHT win trybot!!


>
https://chromiumcodereview.**appspot.com/10897037/<https://chromiumcodereview...
>


-- 
Thiago