First part of PAGE_TRANSITION_START_PAGE cleanup.

First part of PAGE_TRANSITION_START_PAGE cleanup.
I replaced START_PAGE with AUTO_TOPLEVEL because that more accurately
describes how its being used in the code.  In a followed CL I will add
specific support for startup pages, which was the original intention of
START_PAGE.

This CL is basically a large search and replace and does not change the
behaviour of the code.

BUG=144002
TEST=No user visible change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155047

[Roger Tawa OOO till Jul 10th, 2012-08-30 17:43:46]

Hi Peter, Joi, Tim, Scott,

This is an initial change for crbug.com/144002, which only renames an enum.

Peter, Joi: can you make sure this agrees with what we discussed.  Suggestions
for changes/additions to the comment associated to the new enum more than
welcome.

Tim: what are the implications of changing the protobuf? See 
chrome\browser\sync, sync\protocol.  The sync integration tests fail  to
complete and are marked orange, but there does not seem to be any test failures
reported.  See this example:
http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/56934/...

Sky: Can you please do an owner review.

Thanks.

[Peter Kasting, 2012-08-30 19:05:16]

LGTM

http://codereview.chromium.org/10897034/diff/16004/content/public/common/page...
File content/public/common/page_transition_types.h (right):

http://codereview.chromium.org/10897034/diff/16004/content/public/common/page...
content/public/common/page_transition_types.h:61: // loaded in a toplevel frame.
 Use this transition if none of the others are
Nit: I don't think we should say the last sentence here.  If there is a
non-toplevel navigation for which no other transitions are applicable, we
wouldn't want this type used for it.

Instead maybe you can list a couple of examples of valid uses of this.

[sky, 2012-08-30 20:20:02]

LGTM

[Roger Tawa OOO till Jul 10th, 2012-08-31 17:47:54]

Thanks Peter.  Examples added to comment.  Changes uploaded.

http://codereview.chromium.org/10897034/diff/16004/content/public/common/page...
File content/public/common/page_transition_types.h (right):

http://codereview.chromium.org/10897034/diff/16004/content/public/common/page...
content/public/common/page_transition_types.h:61: // loaded in a toplevel frame.
 Use this transition if none of the others are
On 2012/08/30 19:05:16, Peter Kasting wrote:
> Nit: I don't think we should say the last sentence here.  If there is a
> non-toplevel navigation for which no other transitions are applicable, we
> wouldn't want this type used for it.
> 
> Instead maybe you can list a couple of examples of valid uses of this.

Done.

[commit-bot: I haz the power, 2012-08-31 18:26:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/10897034/18006

[commit-bot: I haz the power, 2012-08-31 18:27:04]

Presubmit check for 10897034-18006 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/public
    sync

Presubmit checks took 3.0s to calculate.

[Jói, 2012-08-31 18:29:54]

LGTM
(you should be down to needing someone from sync/OWNERS)

[tim (not reviewing), 2012-09-05 17:25:24]

On 2012/08/31 18:29:54, Jói wrote:
> LGTM
> (you should be down to needing someone from sync/OWNERS)

sync LGTM

[tim (not reviewing), 2012-09-05 17:28:47]

On 2012/09/05 17:25:24, timsteele wrote:
> On 2012/08/31 18:29:54, Jói wrote:
> > LGTM
> > (you should be down to needing someone from sync/OWNERS)
> 
> sync LGTM

Although please build the run_testserver target, and run:

out/Debug/run_testserver --sync-test

as a safety / sanity check that we don't reference these fields in python.

[Roger Tawa OOO till Jul 10th, 2012-09-05 19:19:13]

Thanks Tim.  Built target and all tests passed.

[commit-bot: I haz the power, 2012-09-05 20:44:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/10897034/15005

[commit-bot: I haz the power, 2012-09-05 23:31:14]

Change committed as 155047