Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 10897033: Now with unit test fixes. [Try 2 with fixes for unit tests.] (Closed)

Created:
8 years, 3 months ago by Elliot Glaysher
Modified:
8 years, 3 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Now with unit test fixes. [Try 2 with fixes for unit tests.] Make history easily filterable. We're renaming the two profile directories that we want to keep, and dropping GTK specific tests in anticipation of the changeover later this year. Every change to the history, theme or profile format required a new giant binary file added to our repository. There are tens of versions of the history database alone, each weighing at over 10 megabytes. In the proposed pruned git repository, these are the largest files. This standardizes both remaining test profile directories on the same set of binaries (they're currently out of sync), and moves them to new path names so we can purge the previous paths from history. BUG=111570 TEST=none TBR=pkotwicz,brettw First Review URL: https://chromiumcodereview.appspot.com/10698009 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154448

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-35 lines, -196 lines) Patch
chrome/browser/history/history_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
chrome/browser/themes/browser_theme_pack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/profiles/complex_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUY_c8CDA View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYj9gCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYjNgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYnMgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYw8gCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYwsgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/manifest.json View 1 chunk +0 lines, -35 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/Current Version View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/PreferencesTemplate View 1 chunk +0 lines, -69 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Thumbnails View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/custom_frame/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/custom_frame/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame/Default/Preferences View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/profiles/custom_frame/Default/Thumbnails View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/custom_frame/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/custom_frame_gtk_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Preferences View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Thumbnails View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/gtk_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/gtk_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/gtk_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/gtk_theme/Default/Preferences View 1 chunk +0 lines, -16 lines 0 comments Download
chrome/test/data/profiles/gtk_theme/Default/Thumbnails View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/gtk_theme/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Cookies View Binary file 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUY_c8CDA View Binary file 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYj9gCDA View Binary file 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYjNgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYnMgCDA View Binary file 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYw8gCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYwsgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/Current Version View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Full Text Index View Binary file 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/History View Binary file 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/PreferencesTemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Visited Links View Binary file 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Favicons View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Preferences View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Top Sites View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_default_theme/Default/Visited Links View Binary file 0 comments Download
A + chrome/test/data/profiles/profile_with_default_theme/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/Favicons View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/typical_history/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/Preferences View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/Top Sites View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/typical_history/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/typical_history/README.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/test/perf/feature_startup_test.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 1 chunk +0 lines, -17 lines 0 comments Download
chrome/test/ui/ui_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +8 lines, -12 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
The same as the last time, except also updates two unit tests that had hard ...
8 years, 3 months ago (2012-08-29 21:34:33 UTC) #1
Paweł Hajdan Jr.
LGTM with a comment. https://chromiumcodereview.appspot.com/10897033/diff/1/chrome/test/ui/ui_test.cc File chrome/test/ui/ui_test.cc (right): https://chromiumcodereview.appspot.com/10897033/diff/1/chrome/test/ui/ui_test.cc#newcode434 chrome/test/ui/ui_test.cc:434: DCHECK(file_util::PathExists(source_history_file)); We should avoid DCHECKS ...
8 years, 3 months ago (2012-08-30 08:59:13 UTC) #2
Elliot Glaysher
8 years, 3 months ago (2012-08-31 16:58:01 UTC) #3
TBRing string changes

Powered by Google App Engine
This is Rietveld 408576698