Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Unified Diff: src/api.cc

Issue 10897027: Revert r12379 (Add checks to external string API). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 101361db0dab0248d7f7cc090e973cd8c49bf0db..65b544c7919eae9cb63119d7c0131b9be357ac73 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -537,13 +537,11 @@ Extension::Extension(const char* name,
: name_(name),
source_length_(source_length >= 0 ?
source_length :
- static_cast<int>(strlen(source))),
+ (source ? static_cast<int>(strlen(source)) : 0)),
source_(source, source_length_),
dep_count_(dep_count),
deps_(deps),
- auto_enable_(false) {
- CHECK(source);
-}
+ auto_enable_(false) { }
v8::Handle<Primitive> Undefined() {
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698