Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 10897020: Convert plugins_check.py to a browser test. (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Convert plugins_check.py to a browser test. BUG=143637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -158 lines) Patch
M chrome/browser/chrome_plugin_browsertest.cc View 3 chunks +43 lines, -11 lines 0 comments Download
D chrome/test/data/chromeos_plugins_list.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/data/mac_plugins_list.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/win_plugins_list.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/functional/plugins_check.py View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 3 months ago (2012-08-29 00:12:38 UTC) #1
scottmg
lgtm (all the crap about boards isn't needed, right?
8 years, 3 months ago (2012-08-29 00:36:51 UTC) #2
jam
8 years, 3 months ago (2012-08-29 00:39:03 UTC) #3
On 2012/08/29 00:36:51, scottmg wrote:
> lgtm
> 
> (all the crap about boards isn't needed, right?

yeah, the list was the same for all of them.

Powered by Google App Engine
This is Rietveld 408576698