Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/unittest/config.dart

Issue 10897016: Testrunner for 3rd parties. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/unittest/test_case.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/config.dart
===================================================================
--- pkg/unittest/config.dart (revision 11393)
+++ pkg/unittest/config.dart (working copy)
@@ -104,11 +104,7 @@
var success = false;
if (passed == 0 && failed == 0 && errors == 0) {
print('No tests found.');
- // This is considered a failure too: if this happens you probably have a
- // bug in your unit tests, unless you are filtering.
- if (filter != null) {
- success = true;
- }
+ // This is considered a failure too.
} else if (failed == 0 && errors == 0 && uncaughtError == null) {
print('All $passed tests passed.');
success = true;
« no previous file with comments | « no previous file | pkg/unittest/test_case.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698