Testrunner for 3rd parties.

utils/testrunner/pipeline_runner.dart

+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// A [PipelineRunner] represents the execution of our pipeline for one test

[Siggi Cherem (dart-lang), 2012/08/29 01:05:55]

see general style comments in testrunner.dart (e.g. use /** */ here and below,
add empty line before each comment on the fields below, etc)

[gram, 2012/08/29 20:12:26]

Done.

+// file.
+class PipelineRunner {
+  // The path of the test file.
+  Path _path;
+  // The pipeline template.
+  List _pipelineTemplate;
+  // String lists used to capture output.
+  List _stdout;
+  List _stderr;
+  // Whether the output should be verbose.
+  bool _verbose;
+  // Which stage of the pipeline is being executed.
+  int _stageNum;
+  // The handler to call when the pipeline is done.
+  Function _completeHandler;
+
+  PipelineRunner(
+      List pipelineTemplate,
+      String test,
+      bool verbose,
+      Function completeHandler) :
+    _verbose = verbose,
+    _completeHandler = completeHandler {
+    _pipelineTemplate = pipelineTemplate;
+    _path = new Path(test);
+    _stdout = new List();
+    _stderr = new List();
+  }
+
+  void execute() {
+    runStage(_stageNum = 0);
+  }
+
+  void runStage(int stageNum) {
+    _pipelineTemplate[stageNum].
+        execute(_path, _stdout, _stderr, _verbose, handleExit);
+  }
+
+  // [handleExit] is called at the end of each stage. It will execute the
+  // next stage or call the completion handler if all are done.
+  void handleExit(int exitCode) {
+    int totalStages = _pipelineTemplate.length;
+    ++_stageNum;

[Siggi Cherem (dart-lang), 2012/08/29 01:05:55]

style nit: prefer postfix ++

[gram, 2012/08/29 20:12:26]

Is there a good reason for this? Maybe I'm just showing my age, but back in the
Jurassic period, postinc/dec was considered inferior unless actually needed as
it could result in the creation of unnecessary temporaries, while a prefix
inc/dec could typically be translated into a single machine INC/DEC instruction.

I don't mind changing it; I'm just wondering why there would be a preference for
postfix.

+    String suffix = _verbose ? ' (step $_stageNum of $totalStages)' : '';
+
+    if (_verbose && exitCode != 0) {
+      _stderr.add('Test failed$suffix, exit code $exitCode\n');
+    }
+
+    if (_stageNum == totalStages || exitCode != 0) { // Done with pipeline.
+      completeHandler(makePathAbsolute(_path.toString()), exitCode,
+          _stdout, _stderr);
+    } else {
+      if (_verbose) {
+        _stdout.add('Finished $suffix\n');
+      }
+      runStage(_stageNum);
+    }
+  }
+}